Closed Bug 1758030 Opened 3 years ago Closed 3 years ago

Accessibility review of about:privatebrowsing Fx100

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Iteration:
101.2 - April 18 - April 29
a11y-review changes required

People

(Reporter: pdahiya, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

Fx100 will have a tab modal opening on click of promo button on about:privatebrowsing page. This will be default UI and should be accessible.

Summary: Accessibility review of PBM Fx100 → Accessibility review of about:privatebrowsing Fx100
Assignee: nobody → emcminn
Iteration: --- → 99.2 - Feb 21 - Mar 6
Priority: -- → P1
Iteration: 99.2 - Feb 21 - Mar 6 → 100.1 - March 1 - March 18
Depends on: 1759915
Depends on: 1759918

There are a few things that come up in the devtools accessibility inspector, but they are also present in the release version of the Private Browsing page, so instead of filing a bug for them I'm just going to make note of them here.

  • The page is missing a document title
  • The Google search bar should be keyboard accessible
  • The text inside the google search bar is low contrast
Iteration: 100.1 - March 1 - March 18 → 100.2 - March 21 - April 1
Depends on: 1761842

re-posting my findings from slack --

  1. The image needs to be marked presentational so screen readers don’t pick it up.
  2. The “download firefox focus” link/button does not get focus with the keyboard — also is this a link or a button? visually it’s styled as a button, but to screen readers it’s announced as a link.
  3. The close button is in a non-standard location — could we move it to the upper-right corner of this content instead of having it align horizontally with the text?
  4. It’d be helpful to give this message a different background color so it is evident to the user that this is a dismissable message, instead of just new private-browsing newtab content. This would help users with cognitive disabilities.
  5. The close button doesn’t have an outline or differentiating background to indicate it is a control
  6. nits for windows HCM:
  • the download button should have a border (color: ButtonText) when it is hovered so the text itself doesn’t bleed into the background
  • the border on the close button should use ButtonText
  • the google play and app store buttons in the dialog seem to be images, and the images already have borders so adding the button border like we’d normally makes it look fuzzy/visually indistinct. Ideally I’d remove the border from the image and rely on the CSS styling to add the (dynamic) border back in, but we could also remove the border in HCM since this content wont be adaptive anyway (and I think having the additional border here is actually harming the UX)
a11y-review: --- → changes required
Depends on: 1762431
Depends on: 1762433
Iteration: 100.2 - March 21 - April 1 → 101.1 - April 4 - April 15
Iteration: 101.1 - April 4 - April 15 → 101.2 - April 18 - April 29

Since all the blocking bugs have landed and been verified, I'm going to mark this resolved.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.