Closed Bug 1758055 Opened 3 years ago Closed 2 years ago

Establish file system content and parent process IPC

Categories

(Core :: DOM: File, task, P3)

Product:
Core
Component:
DOM: File
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jjalkanen, Assigned: jjalkanen)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

Bug 1758055 - Establish file system content and parent process IPC. r=jesup,janv,#dom-storage-reviewers,#ipc-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1758055 - Move DOM bindings to api folder. r=jesup,janv,#dom-storage-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1758055 - Add PrincipalInfo to PBackgroundFileSystem construction; r=#dom-storage
(deleted), text/x-phabricator-request
Details
Bug 1758055 - Remove unnecessary origin argument from GetRoot; r=#dom-storage
(deleted), text/x-phabricator-request
Details
No description provided.
Blocks: 1758092
Blocks: OPFS
No longer depends on: OPFS
Status: NEW → ASSIGNED
Blocks: 1758324
No longer blocks: 1758092

Comment on attachment 9266433 [details]
WIP: Bug 1758055 - Establish file system content and parent process IPC.

Revision D140300 was moved to bug 1758324. Setting attachment 9266433 [details] to obsolete.

Attachment #9266433 - Attachment is obsolete: true
Blocks: 1760314
No longer blocks: 1760314
Depends on: 1758320
Attachment #9266745 - Attachment description: WIP: Bug 1758055 - Establish file system content and parent process IPC. → Bug 1758055 - Establish file system content and parent process IPC. r=#dom-storage-reviewers
Attachment #9266745 - Attachment description: Bug 1758055 - Establish file system content and parent process IPC. r=#dom-storage-reviewers → WIP: Bug 1758055 - Establish file system content and parent process IPC.
Attachment #9266745 - Attachment description: WIP: Bug 1758055 - Establish file system content and parent process IPC. → Bug 1758055 - Establish file system content and parent process IPC. r=nika,jesup,janv,#dom-storage-reviewers,#ipc-reviewers
Keywords: leave-open
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ffa45c6af89 Move DOM bindings to api folder. r=janv,dom-storage-reviewers

These changes are partially copied from D148179 (created by jesup). We need to
be able to create correct origin directories from the very beginning.

The origin string is supposed to be generated from PrincipalInfo using a
dedicated QuotaManager method.

Depends on D149259

Attachment #9266745 - Attachment description: Bug 1758055 - Establish file system content and parent process IPC. r=nika,jesup,janv,#dom-storage-reviewers,#ipc-reviewers → Bug 1758055 - Add PrincipalInfo to PBackgroundFileSystem construction; r=#dom-storage

The origin string is supposed to be generated from PrincipalInfo using a
dedicated QuotaManager method.

Depends on D149259

Attachment #9281640 - Attachment is obsolete: true
Attachment #9266745 - Attachment description: Bug 1758055 - Add PrincipalInfo to PBackgroundFileSystem construction; r=#dom-storage → Bug 1758055 - Establish file system content and parent process IPC. r=nika,jesup,janv,#dom-storage-reviewers,#ipc-reviewers
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e304bf129b7 Establish file system content and parent process IPC. r=janv,dom-storage-reviewers

Backed out changeset 8e304bf129b7 (bug 1758055) for causing build bustages in nsISupportsImpl

Backout link: https://hg.mozilla.org/integration/autoland/rev/d595070ce37139fff6e6688a4f192737fc0f8bc8

Push with failures

Failure log

from Unified_cpp_dom_fs_test_gtest0.cpp:2:
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -  /builds/worker/checkouts/gecko/dom/fs/test/gtest/FileSystemMocks.h: In member function 'MozExternalRefCountType mozilla::dom::fs::test::TestPromiseListener<SuccessHandler, ErrorHandler, MilliSeconds>::AddRef()':
[task 2022-06-23T14:02:51.044Z] 14:02:51    ERROR -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:33:3: error: static assertion failed: Reference-counted class WaitablePromiseListener should not have a public destructor. Make this class's destructor non-public
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -     static_assert(!mozilla::IsDestructible<X>::value,      \
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -     ^
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:669:5: note: in expansion of macro 'MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING'
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -       MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING(_class)
Flags: needinfo?(jjalkanen)

Jari Jalkanen, a reminder that we are in soft code freeze for 103.
This looks like a large change to land during code freeze?

Attachment #9266745 - Attachment description: Bug 1758055 - Establish file system content and parent process IPC. r=nika,jesup,janv,#dom-storage-reviewers,#ipc-reviewers → Bug 1758055 - Establish file system content and parent process IPC. r=jesup,janv,#dom-storage-reviewers,#ipc-reviewers
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f0203d4d8553 Establish file system content and parent process IPC. r=janv,dom-storage-reviewers
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/956cb953a945 Add PrincipalInfo to PBackgroundFileSystem construction; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/06134781ceaf Remove unnecessary origin argument from GetRoot; r=dom-storage-reviewers,jari

So the test which was fixed in the second patch was made to pass also in the first one, and both of them were landed after the code freeze.

Flags: needinfo?(jjalkanen)
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: