nsEditingSession needs to detect the mimetype of a url being loaded and send the caller back an error if the mimetype can't be handled. * The mime type should come from the webbrowser listener. * There should be an error if there is a mismatch with what is requested and the actual type. * null or empty string matches whatever the mimetype is (or "mail")

patch that will give you the content type of the document currently attempting to be edited. doesnt do anything with the information yet. This patch is to start some discussion

- rv = SetupFrameControllers(aWindow, htmlController); - if (NS_FAILED(rv)) return rv; Why don't we want to set up controllers right at the time of MakeWindowEditable? The idea was that they controllers and their commands would be available, but that all the commands would be disabled (because there isn't an editor yet). + mEditorClassString = strdup(aEditorType); ... + delete [] mEditorClassString; Mismatched new/delete. You should use free() on the result of strdup(). + nsCOMPtr<nsIControllerContext> editorController = do_QueryInterface(controller); ... + nsCOMPtr<nsIControllerContext> composerController = do_QueryInterface(controller); Do you need these lines at all? You don't do anything with them.

Fixed as part of work on bug 170353

rs vrfy.