Closed Bug 1759749 Opened 3 years ago Closed 3 years ago

Intermittent /html/cross-origin-opener-policy/resource-popup.https.html | assertion count 2 is more than expected 0 assertions | After ASSERTION: we should have saved a frame property: 'Error'

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox98 --- unaffected
firefox99 --- unaffected
firefox100 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

References

(Regression)

Details

(Keywords: assertion, intermittent-failure, regression, Whiteboard: [stockwell needswork:owner], [wptsync upstream])

Attachments

(2 files)

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=371153367&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HDlNnsc7QBqpeOG6NB-HDQ/runs/0/artifacts/public/logs/live_backing.log


[task 2022-03-15T20:05:00.936Z] 20:05:00     INFO - PID 6336 | [Parent 4992, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:95
[task 2022-03-15T20:05:00.963Z] 20:05:00     INFO - PID 6336 | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2022-03-15T20:05:01.442Z] 20:05:01     INFO - PID 6336 | [Parent 4992, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:95
[task 2022-03-15T20:05:01.526Z] 20:05:01     INFO - PID 6336 | [Child 1972, Main Thread] ###!!! ASSERTION: we should have saved a frame property: 'Error', file /builds/worker/checkouts/gecko/layout/painting/nsDisplayList.cpp:4026
[task 2022-03-15T20:05:01.530Z] 20:05:01     INFO - PID 6336 | [Child 1972, Main Thread] ###!!! ASSERTION: we should have saved a frame property: 'Error', file /builds/worker/checkouts/gecko/layout/painting/nsDisplayList.cpp:4026
[task 2022-03-15T20:05:01.574Z] 20:05:01     INFO - Got content assert count 2
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - 
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - TEST-KNOWN-INTERMITTENT-FAIL | /html/cross-origin-opener-policy/resource-popup.https.html | /common/dummy.xml - parent COOP: ""; child COOP: "same-origin" - assert_equals: expected (object) null but got (string) "FAIL"
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - validate@https://web-platform.test:8443/html/cross-origin-opener-policy/resource-popup.https.html:63:20
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - coop_resource_test/</bc.onmessage<@https://web-platform.test:8443/html/cross-origin-opener-policy/resource-popup.https.html:26:57
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:2534:25
[task 2022-03-15T20:05:01.579Z] 20:05:01     INFO - Test.prototype.step_func_done/<@https://web-platform.test:8443/resources/testharness.js:2609:32
[task 2022-03-15T20:05:01.589Z] 20:05:01     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin-opener-policy/resource-popup.https.html | assertion count 2 is more than expected 0 assertions
[task 2022-03-15T20:05:01.589Z] 20:05:01     INFO - ...........
[task 2022-03-15T20:05:01.589Z] 20:05:01     INFO - TEST-OK | /html/cross-origin-opener-policy/resource-popup.https.html | took 3443ms

Before this patch we might not update the ink overflow areas when
'outline-style' changes without changing outline-width, if
'outline-width' was zero.

This was triggered by TopLevelVideoDocument which had 'outline-width: 0'
which before bug 1759602 disabled the default outline.

The test reliably triggers the assertion (though I think we should try
to avoid the frame property in the common case the inner rect and frame
rects just match, which would remove the assertion...).

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Now that we don't include overflow in outlines (bug 1739894) the
overwhelmingly common case is that innerRect == GetRectRelativeToSelf(),
except on a couple special cases.

Avoid storing the property in those cases. The test introduced in the
patch above still ensures we invalidate rendering correctly even without
the presence of the assert.

Depends on D141320

I took a look since bug 1759602 made this more frequent. I think this was really caused by bug 1759602.

Flags: needinfo?(mikokm)
Regressed by: 1759602

Set release status flags based on info from the regressing bug 1759602

Has Regression Range: --- → yes
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aec742599e3d Fix nsStyleOutline::CalcDifference to account for 'outline-style: auto' properly. r=dholbert https://hg.mozilla.org/integration/autoland/rev/eebddb9a5984 Avoid heap-allocating a rect property for most common outline case. r=dholbert

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

I took a look since bug 1759602 made this more frequent. I think this was really caused by bug 1759602.

Thank you. I was going to bisect this today but this saved a lot of time. :)

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33259 for changes under testing/web-platform/tests
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Component: DOM: Core & HTML → CSS Parsing and Computation
Blocks: 1221888
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: