Closed Bug 1759824 Opened 3 years ago Closed 3 years ago

Prepare tests for the removal of the old Address Book

Categories

(Thunderbird :: Address Book, task)

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
100 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

There's a bunch of tests in mail/test/browser that depend on the old Address Book front end existing. In this bug I'll alter tests where necessary and also move and upgrade some tests that we want to keep once the old front end goes away. At that point I'll be removing mail/test/browser/addrbook.

I'm putting this test with the code it tests, and making it cover much more.

In the near future I'll be removing the mail/test/browser/addrbook directory, but we need to keep this test so I've moved it in with the other address book tests and replaced the Mozmill idioms.

Depends on D141197

These tests rely on being able to open the Address Book window, which is going away. Open a different window instead.

Keywords: leave-open
Target Milestone: --- → 100 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/5287a833a2f5 Add a new test for the compose window contacts sidebar. r=mkmelin https://hg.mozilla.org/comm-central/rev/e74b18f4eca2 Move and upgrade the address book telemetry test. r=mkmelin https://hg.mozilla.org/comm-central/rev/c5ea87646a53 Change tests that depend on the old Address Book front end. r=mkmelin

There's a problem trying to click on the address book menulist before the window is ready. I thought I had it reasonably well solved, but apparently not.
Also in this patch I've made the cleanup checks in head.js run after any other registered cleanup listeners, so that they can be used properly.

Attachment #9268402 - Attachment is obsolete: true

I backed out the sidebar test, it has more issues that I first thought.

Backout:
https://hg.mozilla.org/comm-central/rev/fa682b09a0669c1991be0fbad73e0f598b12d916

Attachment #9268614 - Attachment is obsolete: true
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/0df422fd9ee3 Add a new test for the compose window contacts sidebar. r=mkmelin
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/7462ca7c367a Move browser_cardDAV_oAuth.js from mailnews to mail. r=#thunderbird-reviewers,freaktechnik

I think we're done here.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: