User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

1. Open Firefox Settings > Search > Search shortcuts
2. Click Add button
3. type in "Google", filling in other fields (URL, shortcut)

Actual results:

The filed border turns red, filling in other fields doesn't help, new Google search cannot be added. No reason is provided on why this happens

Expected results:

The add function should work as expected and allow me to add Google search.

Note that the default Google search was removed as it does not work properly. Using the default search provider opens Google in a language that is not English.

The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

(In reply to Gleb from comment #0)

Steps to reproduce:

1. Open Firefox Settings > Search > Search shortcuts
2. Click Add button
3. type in "Google", filling in other fields (URL, shortcut)

Can you please elaborate on where/how do you get an "Add button" to add a search engine?

Here's the screenshot of the "Add" button.

It appears that a clean Firefox profile does not have this button. I'm not sure how I got this, but I guess it is not officially supported? I don't have any addons that modify search engine settings.

In any case, I cannot add search with a name Google either. If a visit a website that offers a search plugin via link rel attribute, then if the name of the search is Google, then it cannot be added.

(In reply to Gleb from comment #4)

It appears that a clean Firefox profile does not have this button. I'm not sure how I got this, but I guess it is not officially supported? I don't have any addons that modify search engine settings.

The only guess I have is that you do have an extension that adds that button there. Would be useful if you could narrow down which extension does that, to see what that button tries to do.

In any case, I cannot add search with a name Google either. If a visit a website that offers a search plugin via link rel attribute, then if the name of the search is Google, then it cannot be added.

An use case would be useful, but IMO, it would be wrong for any Open Search engine or otherwise to identify as a built in engine.

(In reply to Adrian Florinescu [:aflorinescu] from comment #5)

The only guess I have is that you do have an extension that adds that button there. Would be useful if you could narrow down which extension does that, to see what that button tries to do.

There's an hidden pref (bug 1106626, browser.urlbar.update2.engineAliasRefresh).

Default search plugins can't be removed, they're only hidden, that's why it doesn't allow you to add a search engine with that name.

Note that the default Google search was removed as it does not work properly. Using the default search provider opens Google in a language that is not English.

The language of the results depends on a lot of results (location, language settings if you're logged in). What's the domain of the default URL, and what's the language of the results?

(In reply to Francesco Lodolo [:flod] from comment #6)

Default search plugins can't be removed, they're only hidden, that's why it doesn't allow you to add a search engine with that name.

Then you should consider renaming the button. It clearly states "Remove", not "Hide".

The language of the results depends on a lot of results (location, language settings if you're logged in). What's the domain of the default URL, and what's the language of the results?

Google uses location / IP address to determine the language of the UI. This makes all interface in the language of the Geo IP (e.g. German, Russian, etc), which is not very user friendly. Changing the default language interface is possible by adding hl=en parameter, but it is not possible with the default search engine. I can login and change interface in Google settings, but if I open Google search in Private tab, then it doesn't work.

So I have to create my own search engine. "Google" is the most obvious name for this.

An use case would be useful, but IMO, it would be wrong for any Open Search engine or otherwise to identify as a built in engine.

Create XML plugin, create HTML with link rel attribute, create a simple HTTP server, open the HTML and right click on the search address bar. If search name is "Google", then it cannot be added.

(In reply to Gleb from comment #7)

(In reply to Francesco Lodolo [:flod] from comment #6)

Default search plugins can't be removed, they're only hidden, that's why it doesn't allow you to add a search engine with that name.

Then you should consider renaming the button. It clearly states "Remove", not "Hide".

Reworking the search preferences UI is something that we're hoping to do at some stage. The rework would also include a better UI around removing/hiding engines.

So I have to create my own search engine. "Google" is the most obvious name for this.

For various reasons we don't allow search engines to have the same name as application provided ones. Before we ship it, this UI would need some UI to explain that re-using existing names isn't allowed, hence I am updating the summary of the bug to reflect that.

Setting as P5 at the moment, as we don't have a current plan for when that UI might ship.