Closed
Bug 1760825
Opened 3 years ago
Closed 3 years ago
Title of new tab page is not properly updated when live language switching
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | verified |
People
(Reporter: standard8, Assigned: gregtatum)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
Preconditions:
user_pref("intl.multilingual.downloadEnabled", true);
user_pref("intl.multilingual.enabled", true);
user_pref("intl.multilingual.liveReload", true);
Install:
language-pack fr
STR:
- Install a firefox Firefox locale, en-us for example (autoset region not that relevant).
- Install language packs from the preconditions.
- Open about:preferences / Language.
- Switch the language to fr.
- Open a new tab.
- Reload the new tab.
- Open a second new tab.
Actual results
- The new tab has the English title "New Tab"
- The tab has the French title "Nouvel onglet"
- The new tab has the English title "New Tab"
Expected results
The French title is used in all instances.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → gtatum
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P1
|
|
Assignee | |
Comment 1•3 years ago
|
||
This adds a utility to load in string bundles in a way that they can be
invalidated. This fixes the short-term bug for the new tab. Bug 1761830
tracks the work to move this to the other call sites.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D142254
|
|
Assignee | |
Comment 3•3 years ago
|
||
This text is cached, and so needs invalidating when the app locale is
changed.
Depends on D142255
|
||
Updated•3 years ago
|
Attachment #9269734 -
Attachment is obsolete: true
|
|
||
Updated•3 years ago
|
Attachment #9269733 -
Attachment is obsolete: true
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0faca4e60dac
Fix New Tab text to change on a live language reload; r=amy
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
||
Comment 6•3 years ago
|
||
Verified as fixed on Firefox 100.0b1 with Mac 11 and Windows 10.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•