Open Bug 1760867 Opened 3 years ago Updated 2 years ago

On Windows 7, yellow dotted focus rings for currently selected item in the Library looks weird when using light themes

Categories

(Firefox :: Theme, defect, P2)

Firefox 97
Unspecified
Windows 7
defect

Tracking

()

Tracking Status
firefox-esr91 --- unaffected
firefox98 --- wontfix
firefox99 --- wontfix
firefox100 --- fix-optional

People

(Reporter: aoia7rz7l, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Confirm that Firefox is currently on a light theme.
  2. open the Library window.
  3. Select random bookmarks.

Expected Behavior:
No yellow dotted focus rings appearing for currently selected item (see 96.0.2).

Actual Behavior:
Yellow dotted focus rings appearing for currently selected item.

Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55986f37737f55b22c4b7ebd4bbdd3ebf8ddeedf&tochange=da44efee8b93dc535742c212967740a736987d27

Not sure why this is happening, but personally the grey background for currently selected item (since Proton?) was already pretty bad, and I am not sure how this yellow dotted border helps. I am sure this is unintentional because this issue is not reproducible on Linux builds, where yellow dotted focus rings have existed since at least ESR 78.

Regressed by: 1747715

Note that the yellow dotted focus rings also became much thicker on at least both Windows and Linux builds since FF98. In this case mozregression returned

Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=51677fbd3e986a517172b69269bf68e50f1f67b0&tochange=c4107f67879e83424cf4e4507e2b3b3e46884328

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Theme

Set release status flags based on info from the regressing bug 1747715

:dao, since you are the author of the regressor, bug 1747715, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Has Regression Range: --- → yes

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0

Hi,

I am able to reproduce the issue in release 98, beta 99 and the latest nightly 100.0a1 (2022-03-23) using Windows 10 as well. See comment 6.

Thanks for the report.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
Attached image FX good vs FX bad.png (deleted) —

(In reply to aoia7rz7l from comment #0)

Expected Behavior:
No yellow dotted focus rings appearing for currently selected item (see 96.0.2).

this issue is not reproducible on Linux builds, where yellow dotted focus rings have existed since at least ESR 78.

Upon further testing, yellow dotted focus rings were also present on ESR 78 (but not on ESR 91) Windows builds, so I guess this was just a matter of me not noticing its removal on Windows during the Photon-to-Proton transition. But then again yellow dotted focus rings against a grey background does look weird on light themes, and if you check out the bookmark/history sidebar on Windows 7, it's still yellow dotted focus rings against a blue background color which is much more pleasant IMO.

Blocks: 1756002
Flags: needinfo?(dao+bmo)
Severity: -- → S4
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: