Closed Bug 1761238 Opened 3 years ago Closed 3 years ago

Title bar checkbox is barely visible with Alpenglow theme inside Customize menu

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
100 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox98 --- wontfix
firefox99 --- wontfix
firefox100 --- verified

People

(Reporter: atrif, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image title_bar (deleted) —

Affected versions

  • 100.0a1 (20220323214810)
  • 99.0b7
  • 98.0.2

Affected platforms

  • Windows 10x64

Preconditions

  • Windows dark theme selected

Steps to reproduce

  1. Open Firefox and set the Alpenglow theme.
  2. Open the Customize menu and observe the Title bar checkbox.

Expected result

  • The checkbox is visible.

Actual result

  • The checkbox is barely visible.

Regression range

Notes

  • Screenshot attached.
  • Not reproducible on Ubuntu 21 and macOS 12.
Has Regression Range: --- → yes
Has STR: --- → yes

:emilio, since you are the author of the regressor, bug 1734115, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

As far as I can tell, we are not using native colors here. This block makes the buttons light, but doesn't make the checkbox light and it probably should.

Component: Widget → Toolbars and Customization
Flags: needinfo?(emilio)
Product: Core → Firefox
Flags: needinfo?(emilio)

That works nicely for both light and dark mode.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)

One additional step in the STR that's critical for testing - on Windows, you must set the "default app mode" for Colours to "Dark" in order to get the dark background in the customization palette.

Priority: -- → P1
Blocks: 1761923
Blocks: 1761926
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67bff9e4ad11 Use ThreeDShadow rather than ThreeDDarkShadow on checkboxes by default. r=dao,mconley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Flags: qe-verify+

Verified fixed with Firefox 100.0b7 (20220417185951) on Windows 10x64. The Title bar check box is visible inside Customize menu with the Alpenglow theme and Dark OS theme.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: