Adjust thank you screen square-ish sizing with noodles, transitions, auto advance without showing Home
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
People
(Reporter: Mardak, Assigned: mviar)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details |
The content is shorter, so the modal appears more rectangular right now
Reporter | ||
Comment 1•3 years ago
|
||
This might not be as noticeable as an issue as now there's only a single screen for 100 upgrade.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
This bug might morph into a more general adjust sizing/spacing of the single thank you screen.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 3•3 years ago
|
||
The has_noodles layout happens to be more-square-ish already. Maybe we'll just morph this bug to include the transitions.
Assignee | ||
Comment 4•3 years ago
|
||
Comment 5•3 years ago
|
||
[Tracking Requested - why for this release]: this is required for Fx100 onboarding treatment
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 7•3 years ago
|
||
bugherder |
Reporter | ||
Comment 8•3 years ago
|
||
Comment on attachment 9270715 [details]
Bug 1762273 - Adjust thank you screen square-ish sizing with noodles, transitions, auto advance without showing Home r=Mardak
Beta/Release Uplift Approval Request
- User impact if declined: Unnecessary about:home opened behind upgrade spotlight without some polish
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- have Firefox pinned/default to test "start browsing" flow
- configure to show upgrade spotlight (
browser.startup.homepage_override.mstone
set to "99",browser.startup.upgradeDialog.version
set to 94) - restart Firefox
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Mainly CSS and JSON configuration changes and reverting about:home showing from bug 1728853
- String changes made/needed: none
Reporter | ||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
I‘ve verified this enhancement using the latest Firefox Nightly 101.0a1 (Build ID: 20220405094056) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.
- The “Thank you” spotlight (“Start browsing” case) is automatically dismissed after ~20 seconds.
- The “Thank you” spotlight (“Start browsing” case) is more rectangular.
- The “Thank you” spotlight no longer opens up a new tab.
Comment 10•3 years ago
|
||
Comment on attachment 9270715 [details]
Bug 1762273 - Adjust thank you screen square-ish sizing with noodles, transitions, auto advance without showing Home r=Mardak
Approved for 100.0b2.
Comment 11•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Comment 12•3 years ago
|
||
I‘ve verified this enhancement using Firefox Beta 100.0b2 (Build ID: 20220405224846) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.
- The “Thank you” spotlight (“Start browsing” case) is automatically dismissed after ~20 seconds.
- The “Thank you” spotlight (“Start browsing” case) is more rectangular.
- The “Thank you” spotlight no longer opens up a new tab.
Description
•