Closed Bug 1762718 Opened 3 years ago Closed 3 years ago

Zap underline can overlap other text

Categories

(Firefox :: Messaging System, defect)

defect

Tracking

()

VERIFIED FIXED
100 Branch
Iteration:
100.2 - March 21 - April 1
Tracking Status
firefox-esr91 --- unaffected
firefox98 --- unaffected
firefox99 --- unaffected
firefox100 --- verified

People

(Reporter: Mardak, Assigned: dmosedale)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

Attached image example overlap zap (deleted) —

There was an unreviewed change that landed as part of https://phabricator.services.mozilla.com/D142744#4666225

Set release status flags based on info from the regressing bug 1762680

:emcminn, since you are the author of the regressor, bug 1762680, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(emcminn)

On it; this was my mistake from a review change.

Assignee: nobody → dmosedale
Flags: needinfo?(emcminn)

So far, I have yet to reproduce this on Mac at all, either in a downloaded en-US nightly, or a local current mozilla-central build. Everything looks pretty normal. I'll go check Windows...

I can't reproduce on Windows 10 inside VMWare either.

The reason I pushed down the Zap was because it seemed a bit too close to the bottom of the last line of text. However, that's not really a big deal compared to the problem found here. I've just attached a patch that backs out only the part that pushes the zap down. Ed, does this fix it for you? If so, then let's just back that part out.

Flags: needinfo?(edilee)

If just backing out the zap vertical positioning change is insufficient to fix it, I've also attached another patch that we can use to just back out the entire zap thickening patch.

Emily can you reproduce this?

Flags: needinfo?(emcminn)
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a83784353e32 Zap underline text overlap in welcome screen, r=Mardak
Flags: needinfo?(emcminn)
Flags: needinfo?(edilee)
Attachment #9270550 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Has Regression Range: --- → yes

This issue was part of the work done on QA-1448 for which we sent a Preliminary checkpoint. Considering this I am marking it as Verified.

Status: RESOLVED → VERIFIED
Iteration: --- → 100.2 - March 21 - April 1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: