Zap underline can overlap other text
Categories
(Firefox :: Messaging System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox98 | --- | unaffected |
firefox99 | --- | unaffected |
firefox100 | --- | verified |
People
(Reporter: Mardak, Assigned: dmosedale)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
There was an unreviewed change that landed as part of https://phabricator.services.mozilla.com/D142744#4666225
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1762680
Comment 2•3 years ago
|
||
:emcminn, since you are the author of the regressor, bug 1762680, could you take a look?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 3•3 years ago
|
||
On it; this was my mistake from a review change.
Assignee | ||
Comment 4•3 years ago
|
||
So far, I have yet to reproduce this on Mac at all, either in a downloaded en-US nightly, or a local current mozilla-central build. Everything looks pretty normal. I'll go check Windows...
Assignee | ||
Comment 5•3 years ago
|
||
I can't reproduce on Windows 10 inside VMWare either.
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Comment 7•3 years ago
|
||
The reason I pushed down the Zap was because it seemed a bit too close to the bottom of the last line of text. However, that's not really a big deal compared to the problem found here. I've just attached a patch that backs out only the part that pushes the zap down. Ed, does this fix it for you? If so, then let's just back that part out.
Assignee | ||
Comment 8•3 years ago
|
||
Assignee | ||
Comment 9•3 years ago
|
||
If just backing out the zap vertical positioning change is insufficient to fix it, I've also attached another patch that we can use to just back out the entire zap thickening patch.
Emily can you reproduce this?
Comment 10•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 11•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 12•3 years ago
|
||
This issue was part of the work done on QA-1448 for which we sent a Preliminary checkpoint. Considering this I am marking it as Verified.
Reporter | ||
Updated•3 years ago
|
Description
•