"error: there is no argument named `arg` in geckodriver" with rustc 1.57.0
Categories
(Testing :: geckodriver, defect, P2)
Tracking
(firefox-esr91 unaffected, firefox99 unaffected, firefox100 fixed, firefox101 fixed)
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox99 | --- | unaffected |
firefox100 | --- | fixed |
firefox101 | --- | fixed |
People
(Reporter: arai, Assigned: whimboo)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Steps to reproduce:
- set rustc 1.57.0 as default
./mach build
on revision 3a5752d614cea0d0a2d1edaff6cc80eb369584a5, withoutmozconfig
file, on Windows
Actual result:
5:25.35 error: there is no argument named `arg`
5:25.35 --> testing\geckodriver\src\capabilities.rs:485:39
5:25.35 |
5:25.35 485 | format!("Argument {arg} can't be set via capabilities"),
5:25.35 | ^^^^^
5:26.87 error: could not compile `geckodriver` due to previous error
5:26.88 mozmake[4]: *** [C:/mozilla-source/mozilla-unified/config/makefiles/rust.mk:490: force-cargo-program-build] Error 101
5:26.89 mozmake[3]: *** [C:/mozilla-source/mozilla-unified/config/recurse.mk:72: testing/geckodriver/target] Error 2
5:26.89 mozmake[3]: *** Waiting for unfinished jobs....
Capturing the argument from the scope is available from rustc 1.58.0, and the current minimum version is 1.57.0
MINIMUM_RUST_VERSION = "1.57.0"
Comment 1•3 years ago
|
||
:whimboo, since you are the author of the regressor, bug 1759994, could you take a look?
For more information, please visit auto_nag documentation.
Comment 2•3 years ago
|
||
meetoo
Assignee | ||
Comment 4•3 years ago
|
||
Sorry, didn't know that there is such a minimum Rust version setting. Will have a patch in a moment.
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
Comment 7•3 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #4)
Sorry, didn't know that there is such a minimum Rust version setting. Will have a patch in a moment.
Another option is updating the minimum rustc version requirement. See bug 1744234 for example.
Assignee | ||
Comment 8•3 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #7)
Another option is updating the minimum rustc version requirement. See bug 1744234 for example.
Sure, but I would leave this actually to Firefox Build System peers given that such a forced minimum version upgrade could cause compiler issues with Rust as well. And fixing other code is not actually something that I have the time for. But thanks for hinting!
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Assignee | ||
Comment 10•3 years ago
|
||
The consequences of this bug is that folks on Windows have issues to build Firefox even it's testing only related. It regressed for Firefox 100 and as such the patch needs to be uplifted to beta. Can someone please do so? Thanks.
Comment 11•3 years ago
|
||
bugherder uplift |
Comment 12•3 years ago
|
||
The minimum Rust requirement has been updated to 1.59 after all. (bug 1763305)
Description
•