Closed Bug 1762865 Opened 3 years ago Closed 2 years ago

Assert server breakpoints in tests

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox101 fixed)

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau
(deleted), text/x-phabricator-request
Details

For non-sourcemapped scenarios, when the location for a pending breakpoint no longer exists after reload (likely because the source has changed and the line has been removed). The breakpoint on the server does not get removed.

Summary: Remove breakpoints for sources when location(line/column) no longer exists → Remove breakpoints on the server for sources when location(line/column) no longer exists

This patch also adds assertions for breakpoints on the server to the
breakpoints reload tests. This also asserts that the breakpoint is not removed
on the server when related source no longer exists after a reload

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Attachment #9270677 - Attachment description: Bug 1762865 - [devtools] Remove server breakpoint on syncing when location in source no longer exists r=ochameau → Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau
Summary: Remove breakpoints on the server for sources when location(line/column) no longer exists → Assert server breakpoints in tests

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bomsy, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(poirot.alex)
Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87cb99924fc4 [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau

Backed out 2 changesets (Bug 1762865, Bug 1764055) for causing devtools failures on browser_dbg-features-breakable-lines.js.
Backout link
Push with failures
Failure Log

Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc3ad1de4635 [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau
Regressions: 1767070

https://hg.mozilla.org/mozilla-central/rev/bc3ad1de4635

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Regressions: 1767188
Flags: needinfo?(hmanilla)
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: