It would be nice if there was a way to disable Fission when running XPCShell tests via mach.

Right now, you have to do it with --setpref fission.autostart=false which is a little awkward.

well right now we don't run with fission enabled, but overall I think we should add this in. We will only be running xpcshell tests without fission on linux- would you prefer that we make this available on all platforms?

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #1)

well right now we don't run with fission enabled, but overall I think we should add this in. We will only be running xpcshell tests without fission on linux- would you prefer that we make this available on all platforms?

mach xpcshell-test runs with Fission enabled, as far as I can tell. Which is a little confusing given that we run without Fission in automation. I don't know how useful this will really be, but yeah, it should be on all platforms. Really, it is just a bit of convenience and consistency.

when I get to cleaning up fission by default, then making --no-fission or --disable-fission will be the mode everywhere; I will keep this on my list for when I land the xpcshell w/fission changes (bug 1751492)

Backed out for causing multiple failures (exit status 2)

• Backout link
• Push with failures
• Failure Log
• Failure line: [taskcluster:error] exit status 2

thanks, I overlooked android hardware tests, fixed the patch and it is up for review.

Backed out for causing jit failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/292df8ed886d5b62860f0d88054c5cbb7e71aea1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=S0VDgwh-Spq1gCnbHG8ftg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1ce55e10b927cda24fd25e4897afe8d37c8ae4ce

Failure log: https://treeherder.mozilla.org/logviewer?job_id=377512045&repo=autoland&lineNumber=1526

The xpcshell failures jumped from tier 2 to tier 1

thanks; I see I overlooked an edge case on desktop- a couple extra try pushes and my patch looks good for another try

https://hg.mozilla.org/mozilla-central/rev/dfcdb4347811

Is it possible this broke some of the benchmarks on AWFY? For example this hasn't been updating the past days: https://arewefastyet.com/win10/benchmarks/raptor-desktop-matrix-react-bench?numDays=60

this is a good question, I see tests still running on mozilla-central every commit:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=matrix-react%2Cwin&fromchange=70a9f214d8d3a5e97b928d2a650a823ba368dea2

the task name hasn't changed at all, but the metadata for the replicates lost the fission tag. I will look into this, it does seem like a regression from this patch.

How can we run fission geckoview-junit tests after this change? Using --setpref fission.autostart=true doesn't work and the test defaults to non-fission mode.

:agi, thanks for catching this. I assume you mean via ./mach. in CI we run geckoview-junit-fis successfully. I think the area of code to fix is:
https://hg.mozilla.org/mozilla-central/rev/dfcdb4347811#l16.2

I suspect there is a simple fix for it. On my short list to look at today.

Yeah I meant locally, I verified in CI that we do the right thing and enable fission for fis jobs. Thanks.

https://hg.mozilla.org/mozilla-central/rev/c4ce96e5fe0a

:jandem, benchmark data is now back- sorry for the ~2 day interruption.

:agi, your issue with junit is still high on my list.

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #23)

:jandem, benchmark data is now back- sorry for the ~2 day interruption.

Thank you! \o/