Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Categories
(Toolkit :: Password Manager, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: serg, Assigned: serg)
References
(Blocks 4 open bugs)
Details
(Whiteboard: [fxcm-relay])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Currently a few items managed by LoginAutoComplete have duplicate implementations - one for the mouse click and one for the ENTER key.
Also we need the ability to asynchronously fill inputs by code running in LoginManagerParent. This will help with Firefox Relay integration, one-time passwords support, decrypting only selected passwords and with other integrations.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Backed out for causing failures at test_autocomplete_highlight_username_only_form.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/aea2c8c7f8ce357237b10996c0c19649feb72230
Failure log: https://treeherder.mozilla.org/logviewer?job_id=373771712&repo=autoland&lineNumber=9567
Assignee | ||
Comment 4•3 years ago
|
||
Atila, I've checked the failure log, all failures are timeouts. Previous try pushes didn't have this issue and I can not reproduce locally with mach try --verify
. I suspect testing infrastructure was overloaded at the moment.
What would be the right way to get it landed? Shall I try to land again?
Comment 5•3 years ago
|
||
Let's try landing it again and see what happens.
Comment 7•3 years ago
|
||
Backed out for causing mochitest failures in test_autocomplete_highlight_username_only_form.html
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_highlight_username_only_form.html | Test timed out. -
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Description
•