Closed Bug 1763047 Opened 3 years ago Closed 3 years ago

Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent

Categories

(Toolkit :: Password Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: serg, Assigned: serg)

References

(Blocks 4 open bugs)

Details

(Whiteboard: [fxcm-relay])

Attachments

(1 file)

Currently a few items managed by LoginAutoComplete have duplicate implementations - one for the mouse click and one for the ENTER key.

Also we need the ability to asynchronously fill inputs by code running in LoginManagerParent. This will help with Firefox Relay integration, one-time passwords support, decrypting only selected passwords and with other integrations.

Assignee: nobody → sgalich
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [fxcm-relay]
Attachment #9270821 - Attachment description: WIP: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent → Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Attachment #9270821 - Attachment description: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent → WIP: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Attachment #9270821 - Attachment description: WIP: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent → Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e9e518bd470 Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi

Atila, I've checked the failure log, all failures are timeouts. Previous try pushes didn't have this issue and I can not reproduce locally with mach try --verify. I suspect testing infrastructure was overloaded at the moment.

What would be the right way to get it landed? Shall I try to land again?

Flags: needinfo?(sgalich) → needinfo?(abutkovits)

Let's try landing it again and see what happens.

Flags: needinfo?(abutkovits)
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1eb6fe5a1fa Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi

Backed out for causing mochitest failures in test_autocomplete_highlight_username_only_form.html

Flags: needinfo?(sgalich)
Attachment #9270821 - Attachment description: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent → WIP: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Attachment #9270821 - Attachment description: WIP: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent → Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2194aa4357f5 Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi
Flags: needinfo?(sgalich)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: