Write fleet of tests to support "sys.path" modification logic
Categories
(Firefox Build System :: Mach Core, task)
Tracking
(firefox101 fixed)
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Cover the various cases and combinations around
- Using different "site packages sources" (VENV/SYSTEM/NONE)
- Using different command virtualenvs (build/common/doc)
- Imports in main processes versus imports in subprocesses
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I'm going to test on top of bug 1761150, which simplifies system-sys-path management significantly
Assignee | ||
Comment 2•3 years ago
|
||
Verify that activating mach and command sites in various configurations
affects the sys.path
accurately.
Also verify that the sys.path
is correct between the "activated
process" and fresh processes spawned from created virtualenvs.
Finally, tweak existing path-management behaviour to be more consistent:
- Don't unnecessarily sort
pths
from requirement definitions - it's
more consistent (and more dependable) to keep the provided order. - Continue removing unwanted
venv
entries from thesys.path
, but
don't add them back (such as the$prefix
entry) - Always remove
venv
entries from thesys.path
when the venv isn't
being populated. Though this doesn't affect behaviour, it makes
assertions easier and simplifies the runtime state a bit.
Depends on D143200
Assignee | ||
Comment 3•3 years ago
|
||
Verify that activating mach and command sites in various configurations
affects the sys.path
accurately.
Also verify that the sys.path
is correct between the "activated
process" and fresh processes spawned from created virtualenvs.
Finally, tweak existing path-management behaviour to be more consistent:
- Don't unnecessarily sort
pths
from requirement definitions - it's
more consistent (and more dependable) to keep the provided order. - Continue removing unwanted
venv
entries from thesys.path
, but
don't add them back (such as the$prefix
entry) - Always remove
venv
entries from thesys.path
when the venv isn't
being populated. Though this doesn't affect behaviour, it makes
assertions easier and simplifies the runtime state a bit.
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Description
•