It would be useful to have a breakdown per thread name of the CPU time and thread wake-ups information that is currently collected per process type.

Comment on attachment 9271144 [details]
data-collection-review request

Actually, I forgot to edit the line that says "All channels, countries, and locales. No filters." The C++ code recording data for these probes is in #ifdef NIGHTLY_BUILD blocks.

Comment on attachment 9271144 [details]
data-collection-review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Florian Quèze is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

Result: datareview+

(In reply to Florian Quèze [:florian] from comment #3)

Comment on attachment 9271144 [details]
data-collection-review request

Actually, I forgot to edit the line that says "All channels, countries, and locales. No filters." The C++ code recording data for these probes is in #ifdef NIGHTLY_BUILD blocks.

And I forgot to read the comments and thus edit my response to say "Default on for Nightly only" : |

Backed out for assertion failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/107eed2f19be9f10f5ae848654985792c799e2a1
Log link (xpc): https://treeherder.mozilla.org/logviewer?job_id=374571086&repo=autoland&lineNumber=1825
Log link: (wpt): https://treeherder.mozilla.org/logviewer?job_id=374573097&repo=autoland&lineNumber=1101

(In reply to Narcis Beleuzu [:NarcisB] from comment #7)

Backed out for assertion failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/107eed2f19be9f10f5ae848654985792c799e2a1
Log link (xpc): https://treeherder.mozilla.org/logviewer?job_id=374571086&repo=autoland&lineNumber=1825
Log link: (wpt): https://treeherder.mozilla.org/logviewer?job_id=374573097&repo=autoland&lineNumber=1101

Should have been fixed by the 2 new patches that recently landed in bug 1763593.

Backed out changeset 700318695e2b (Bug 1763474) for causing GTest failures and mochitest failures on ProfilerThreadRegistrationData.cpp.
Backout link
Push with failures -- mda2 -- GTest-1proc
Failure Log
GTest-1proc Failure Log

https://hg.mozilla.org/mozilla-central/rev/6d54763521f1