Closed Bug 1764504 Opened 3 years ago Closed 3 years ago

Remove obsolete comments about inadequacy of LoadTainting

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/10edce3685369a4c73955cc8d5fcbc5a9d7598af/netwerk/base/LoadTainting.h#28-35

tainting has been set with AsyncOpen2() since https://hg.mozilla.org/integration/mozilla-inbound/rev/989bbde310f5#l6.74 and AsyncOpen() was removed for bug 1520868.

The advice about checking final URL and CORS mode is misleading because the URL and CORS mode of an nsIHttpChannelInternal will reflect the URL and CORS mode of the request, which may differ from those of a ServiceWorker-synthesized Response, with null URL for example.

+++ This bug was initially created as a clone of Bug #1226909 +++

tainting has been set with AsyncOpen2() since
https://hg.mozilla.org/integration/mozilla-inbound/rev/989bbde310f5#l6.74
and AsyncOpen() was removed for
https://bugzilla.mozilla.org/show_bug.cgi?id=1520868

The advice about checking final URL and CORS mode is misleading because the
URL and CORS mode of an nsIHttpChannelInternal will reflect the URL and CORS
mode of the request, which may differ from those of a
ServiceWorker-synthesized Response, with null URL for example.

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5562a7165059 Remove obsolete comments about inadequacy of LoadTainting r=ckerschb,necko-reviewers,dragana DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: