Closed Bug 1764761 Opened 3 years ago Closed 2 years ago

Remove/replace the network.cookie.lifetimePolicy

Categories

(Toolkit :: Data Sanitization, task, P1)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: h.sofie.p, Assigned: h.sofie.p)

References

Details

Attachments

(2 files)

This is part of deprecating and removing the network.cookie.lifetimePolicy.
After relying fully on the sanitizeOnShutdown mechanism (see bug 1681495 and and bug 1681498) the network.cookie.lifetimePolicy can be removed from the code in various places.

(In reply to hpeuckmann@mozilla.com from comment #0)

(see bug 1681495 and and bug 1691498)

bug 1681495 and bug 1681498?
If so, you need to fix "See Also".

Blocks: 1681493
Type: enhancement → task
Severity: -- → N/A
Priority: -- → P1
Attachment #9273625 - Attachment description: WIP: Bug 1764761 - Remove/replace the network.cookie.lifetimePolicy. r=pbz! → Bug 1764761 - Remove/replace the network.cookie.lifetimePolicy. r=pbz!
Pushed by hpeuckmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5625033b31a Remove/replace the network.cookie.lifetimePolicy. r=pbz,necko-reviewers,mkaply,dom-storage-reviewers,agi,asuth,dragana https://hg.mozilla.org/integration/autoland/rev/efa36df51bcf Remove cookie.lifetimePolicy macros ACCEPT_SESSION/NORMALLY. r=pbz,timhuang

Hi All, since this bug is removing the underlying preference set by the "Delete cookies and site data when Firefox is closed" checkbox, hopefully there is a plan for that removing/replacing that checkbox (https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.inc.xhtml#369). However, I don't see it mentioned explicitly here or in bug 1746723 (where I'm mentioning this as well).

Perhaps there should be a "link" to "Clear history when Firefox closes" or to a SUMO KB article to help users find the new way? I think it's important that users do not get the impression that the ability to clear cookies and site data at shut down has been taken away from them.

Is that in scope for this bug?

(In reply to jscher2000 from comment #5)

Hi All, since this bug is removing the underlying preference set by the "Delete cookies and site data when Firefox is closed" checkbox, hopefully there is a plan for that removing/replacing that checkbox (https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.inc.xhtml#369). However, I don't see it mentioned explicitly here or in bug 1746723 (where I'm mentioning this as well).

Perhaps there should be a "link" to "Clear history when Firefox closes" or to a SUMO KB article to help users find the new way? I think it's important that users do not get the impression that the ability to clear cookies and site data at shut down has been taken away from them.

Is that in scope for this bug?

We have changed the checkbox behavior, it now controls the sanitize-on-shutdown feature which should behave the same way that cookie lifetime policy did. Ideally there will be no user-perceived change in behavior. In 103 and ongoing if you check the checkbox you will see that it modifies the sanitizer settings in the "History" section.

See Bug 1681495 for more details.

(In reply to Paul Zühlcke [:pbz] from comment #6)

We have changed the checkbox behavior, it now controls the sanitize-on-shutdown feature which should behave the same way that cookie lifetime policy did. Ideally there will be no user-perceived change in behavior. In 103 and ongoing if you check the checkbox you will see that it modifies the sanitizer settings in the "History" section.

See Bug 1681495 for more details.

Brilliant, thank you.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Regressions: 1777513
Regressions: 1789285
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: