Closed Bug 1764776 Opened 3 years ago Closed 2 years ago

Modifying a bookmark URL from a search doesn't update the result tree

Categories

(Firefox :: Bookmarks & History, defect, P3)

Firefox 99
defect

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox-esr102 --- wontfix
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- fixed

People

(Reporter: marc.rozier, Assigned: daisuke)

References

(Regressed 1 open bug)

Details

(Keywords: regression, Whiteboard: [snt-scrubbed][places-regression])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

Open the bookmark manager
Apply a Filter for a part of a URL
Click on one
Change the name of the URL (not the searched part)

Actual results:

The URL is not updated in the bookmark display

Expected results:

The URL should have been updated in the bookmark display

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

it works for me, this is what I did:

  • I opened the Library (bookmark manager) window
  • I typed a search like "123"
  • I selected a bookmark and changed it's name field value
  • I moved the focus out of the name field (this is necessary to start the update)
  • the name of the bookmark in the upper pane was updated
    I did this in currently Nightly version.

could you please post a short video of the issue?

Flags: needinfo?(marc.rozier)

(In reply to Marco Bonardo [:mak] from comment #2)

it works for me, this is what I did:

  • I opened the Library (bookmark manager) window
  • I typed a search like "123"
  • I selected a bookmark and changed it's name field value
  • I moved the focus out of the name field (this is necessary to start the update)
  • the name of the bookmark in the upper pane was updated
    I did this in currently Nightly version.

could you please post a short video of the issue?

I totally agree with you.
It works fine for the name of the bookmark, but not with the displayed URL address, that is not updated, even while focussing out.

Flags: needinfo?(marc.rozier)

ah yes, you're right, I was confused by name VS url. Not super critical but definitely a bug.

If I modify the url of a bookmark found by a search the list is not refreshed. This may actually be a regression, we recently changed notifications and this looks very similat to bug 1746814.

If I should guess reg-range I'd probably suggest Bug 1678624.

Severity: -- → S4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Summary: Modification of a bookmark while a filter is ON → Modifying a bookmark URL from a search doesn't update the result tree
Blocks: 1473530
QA Whiteboard: [qa-regression-triage]

I reproduced this issue on an affected Nightly build from 2022-04-14, on macOS 10.14.

I ran mozregression and I reached the following regression range:
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88dbe1a7478c82c0c93830cedb88d134c3392382&tochange=d0180eae3832b10e90f9815b0f4f79b071b25dbe

Potential regressor: Bug 1678624

Whiteboard: [snt-scrubbed][search-regression]
Whiteboard: [snt-scrubbed][search-regression] → [snt-scrubbed][places-regression]
Duplicate of this bug: 1795929
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0e57cdb1f74 Update url field on item of list when changing the url on editor while filtering by chars. r=mak
Regressions: 1816886
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: