Closed Bug 1764823 Opened 3 years ago Closed 3 years ago

D3D9DXVA2Manager::SupportsConfig uses output type for testing decoder instantiation, which does not match Microsoft documentation.

Categories

(Core :: Audio/Video: Playback, defect)

Firefox 101
Desktop
Windows
defect

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: Zaggy1024, Assigned: Zaggy1024)

References

Details

Attachments

(1 file)

In D3D9DXVA2Manager::SupportsConfig, it passes the output type to ConvertMFTypeToDXVAType, which is incorrect according to Microsoft documentation:

https://docs.microsoft.com/en-us/windows/win32/medfound/supporting-dxva-2-0-in-directshow#finding-a-decoder-configuration

// Fills in a DXVA2_VideoDesc structure based on the input format.
void FillInVideoDescription(DXVA2_VideoDesc *pDesc);

We should change SupportsConfig to be consistent with this documentation. The output media type from WMFVideoMFTManager does not have MF_MT_FRAME_RATE set, so it should either be set in WMFVideoMFTManager::SetDecoderMediaTypes(), or a placeholder/approximation should be used in SupportsConfig.

Improved the debug description of WMF video decoders to list the DXVA version used as well as the correct output type.

Assignee: nobody → Zaggy1024
Status: NEW → ASSIGNED
Depends on: 1763680
Pushed by zaggy1024@gmail.com: https://hg.mozilla.org/integration/autoland/rev/876973cc9138 When attempting to hardware decode H264 video, the D3D9 DXVA support check will now correctly use the input media type. r=alwu

Re-landing with a fix, it looks like there was a null reference in debug logging.

Flags: needinfo?(Zaggy1024)
Pushed by zaggy1024@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a677ce7701a6 When attempting to hardware decode H264 video, the D3D9 DXVA support check will now correctly use the input media type. r=alwu
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: