Open
Bug 1764895
Opened 2 years ago
Updated 2 years ago
Get rid of nsIEditor.setShouldTxnSetSelection, instead insertNode and deleteNode should have optional argument for equivalent feature
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
ASSIGNED
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 3 open bugs)
Details
nsIEditor.setShouldTxnSetSelection is used only with nsIEditor.insertNode and nsIEditor.deleteNode in comm-central. So, it's enough to make insertNode and deleteNode have new optional argument to do same thing.
The motivation of this is, I want to centralize selection updates instead of each DOM tree updater including transactions do it multiple times because of the performance reason of DOM Selection and making editor implementation simpler.
Additionally, comm-central does not guarantee the clean up of calling nsIEditor.setShouldTxnSetSelection(false) with try-finally. From point of view of this, this API style is a bad design.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
Blocks: redesign-editor-scriptable-API, 1612319
| Comment hidden (off-topic) |
|
||
Comment 2•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
You need to log in
before you can comment on or make changes to this bug.
Description
•