Closed Bug 1764998 Opened 3 years ago Closed 2 years ago

Add API to set process high priority

Categories

(GeckoView :: General, task, P2)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
task

Tracking

(firefox-esr91 wontfix, firefox99 wontfix, firefox100 wontfix, firefox101 wontfix, firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- wontfix
firefox99 --- wontfix
firefox100 --- wontfix
firefox101 --- wontfix
firefox102 --- fixed

People

(Reporter: calu, Assigned: calu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m102])

Attachments

(1 file, 1 obsolete file)

Bug 1764998 - Add geckosession API to set priority
(deleted), text/x-phabricator-request
Details

Instead of deducing the priority based on the extension active priority, add an API to set it high priority. This will allow Gleam metrics to be measured to compare performance and stability metrics for process prioritization on and off.

This API will be needed to run the following experiment measuring the perf and stability impacts of Android process prioritization:

https://mozilla-hub.atlassian.net/browse/MOBEX-22

Severity: -- → N/A
status-firefox100: --- → wontfix
status-firefox101: --- → wontfix
status-firefox99: --- → wontfix
status-firefox-esr91: --- → wontfix
Priority: -- → P2
See Also: → https://mozilla-hub.atlassian.net/browse/MOBEX-22
Whiteboard: [geckoview:m102?]
Assignee: nobody → calu
Whiteboard: [geckoview:m102?] → [geckoview:m102]

Here's an initial draft to the API needed, setProcessPriorityHint: https://docs.google.com/document/d/1xGXQhVLnWBU84WmQ0ebkJ-MqI6o67mXosjxT1p3M26w/edit?usp=sharing

Flags: needinfo?(agi)

Looks good, mostly minor stuff.

Flags: needinfo?(agi)

Thanks for reviewing this, Agi! I add your changes. Who else should review it, or which matrix should I post it in?

Flags: needinfo?(agi)

Thank you! I added one more comment (no need to resend for review). I think it would be good to ask somebody on the Fenix team for review (maybe csadilek) and someone else from our team.

Flags: needinfo?(agi)

Hey Christian, would you be able to review the design doc for adding this API to set priority hint on a geckosession?
https://docs.google.com/document/d/1xGXQhVLnWBU84WmQ0ebkJ-MqI6o67mXosjxT1p3M26w/edit?usp=sharing

Flags: needinfo?(csadilek)

Thank you, API looks good to me! I had one question in the document re: MEDIUM priority, but let's continue there.

Flags: needinfo?(csadilek)
Attached file Bug 1764998 - Add geckosession API to set priority (obsolete) (deleted) —

Corresponding Design Doc: https://docs.google.com/document/d/1xGXQhVLnWBU84WmQ0ebkJ-MqI6o67mXosjxT1p3M26w/edit?usp=sharing

This API will allow apps to set a geckosession/tab to either high priority or default with the priorityHint.

Corresponding Design Doc: https://docs.google.com/document/d/1xGXQhVLnWBU84WmQ0ebkJ-MqI6o67mXosjxT1p3M26w/edit?usp=sharing

This API will allow apps to set a geckosession/tab to either high priority or default with the priorityHint.

Depends on: 1767346
Attachment #9275504 - Attachment is obsolete: true
Depends on: 1753700
Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efab68e4f6b3 Add geckosession API to set priority r=geckoview-reviewers,agi,owlish,jonalmeida

Backed out for causing lint failures on GeckoSession.java

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:0 | Formatting error, please run ./mach lint -l android-format --fix (spotless-java)
Flags: needinfo?(calu)
Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f639bdff32b Add geckosession API to set priority r=geckoview-reviewers,agi,owlish,jonalmeida

https://hg.mozilla.org/mozilla-central/rev/9f639bdff32b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Flags: needinfo?(calu)
Regressions: 1768776
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: