Page Setup menu needs dark mode
Categories
(Toolkit :: Printing, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | verified |
People
(Reporter: joaopauloag-bugsmozilla, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36 Edg/100.0.1185.39
Steps to reproduce:
- Set dark mode theme on Firefox;
- Reenable the Page Setup Menu (go to about:config and set print.show_page_setup_menu=true);
- Open the Menu File \ Page Setup.
Actual results:
The Page Setup is unreadable under dark mode (see the attached images).
Expected results:
The Page Setup should be readable.
Reporter | ||
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
We don't have non-native theme support for these so we can't use dark system
colors.
Assignee | ||
Comment 4•3 years ago
|
||
These look much nicer, and support dark mode.
Depends on D143903
Reporter | ||
Comment 5•2 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)
Created attachment 9272674 [details]
Bug 1765076 - Force native tabs to light on Windows. r=dao,mstriemerWe don't have non-native theme support for these so we can't use dark system
colors.
Could you please stick to the default light theme instead of trying to change the Page Setup to a broken dark theme, then? It's better to be unconsistent than to be unreadable.
Or then change the Page Setup settings to be inside the print preview pane.
Reporter | ||
Comment 6•2 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
Created attachment 9272675 [details]
Bug 1765076 - Use in-content styles for page setup dialog. r=dao,mstriemerThese look much nicer, and support dark mode.
Depends on D143903
Nice! Do you know when will it arrive?
Assignee | ||
Comment 7•2 years ago
|
||
(In reply to João Paulo from comment #5)
Could you please stick to the default light theme instead of trying to change the Page Setup to a broken dark theme, then? It's better to be unconsistent than to be unreadable.
That's what that patch does, what do you mean?
(In reply to João Paulo from comment #6)
Nice! Do you know when will it arrive?
Has to be reviewed yet.
Updated•2 years ago
|
Comment 9•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/933a8a3ddac7
https://hg.mozilla.org/mozilla-central/rev/c66543d7382a
Updated•2 years ago
|
Comment 10•2 years ago
|
||
I managed to reproduce this on Firefox 100.0(20220428192727) on Win10 64-bits. Verified as fixed on Firefox 101.0b6(20220512193916), Nightly 102.0a1(20220512213051) on Win10 64-bits and macOS 11.
Description
•