Closed Bug 1765076 Opened 3 years ago Closed 2 years ago

Page Setup menu needs dark mode

Categories

(Toolkit :: Printing, defect, P3)

Firefox 99
defect

Tracking

()

VERIFIED FIXED
101 Branch
Tracking Status
firefox101 --- verified

People

(Reporter: joaopauloag-bugsmozilla, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Attached image PageSetup1.png (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36 Edg/100.0.1185.39

Steps to reproduce:

  1. Set dark mode theme on Firefox;
  2. Reenable the Page Setup Menu (go to about:config and set print.show_page_setup_menu=true);
  3. Open the Menu File \ Page Setup.

Actual results:

The Page Setup is unreadable under dark mode (see the attached images).

Expected results:

The Page Setup should be readable.

Attached image PageSetup2.png (deleted) —

The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Printing: Output
Product: Firefox → Core
Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Component: Printing: Output → Printing
Ever confirmed: true
Product: Core → Toolkit

We don't have non-native theme support for these so we can't use dark system
colors.

These look much nicer, and support dark mode.

Depends on D143903

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Created attachment 9272674 [details]
Bug 1765076 - Force native tabs to light on Windows. r=dao,mstriemer

We don't have non-native theme support for these so we can't use dark system
colors.

Could you please stick to the default light theme instead of trying to change the Page Setup to a broken dark theme, then? It's better to be unconsistent than to be unreadable.

Or then change the Page Setup settings to be inside the print preview pane.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Created attachment 9272675 [details]
Bug 1765076 - Use in-content styles for page setup dialog. r=dao,mstriemer

These look much nicer, and support dark mode.

Depends on D143903

Nice! Do you know when will it arrive?

(In reply to João Paulo from comment #5)

Could you please stick to the default light theme instead of trying to change the Page Setup to a broken dark theme, then? It's better to be unconsistent than to be unreadable.

That's what that patch does, what do you mean?

(In reply to João Paulo from comment #6)

Nice! Do you know when will it arrive?

Has to be reviewed yet.

Severity: -- → S3
Priority: -- → P3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/933a8a3ddac7 Force native tabs to light on Windows. r=mstriemer https://hg.mozilla.org/integration/autoland/rev/c66543d7382a Use in-content styles for page setup dialog. r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Blocks: dark-mode
Regressions: 1767441
Flags: qe-verify+

I managed to reproduce this on Firefox 100.0(20220428192727) on Win10 64-bits. Verified as fixed on Firefox 101.0b6(20220512193916), Nightly 102.0a1(20220512213051) on Win10 64-bits and macOS 11.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1787662
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: