Closed Bug 1765145 Opened 3 years ago Closed 3 years ago

The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled

Categories

(Firefox :: Messaging System, defect, P2)

Product:
Firefox
Component:
Messaging System
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
102 Branch
Iteration:
102.1 - May 2 - May 13
Tracking Flags:
Tracking Status
firefox99 --- unaffected
firefox100 --- wontfix
firefox101 --- unaffected
firefox102 --- verified

People

(Reporter: cbulz, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

rec of the issue.gif
(deleted), image/gif
Details
Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled
(deleted), text/x-phabricator-request
Details
Attached image rec of the issue.gif (deleted) —

[Affected versions]:

  • Firefox Beta 100.0b7 (Build ID: 20220417185951)
  • Firefox Nightly 101.0a1 (Build ID: 20220417212536)

[Affected Platforms]:

  • Windows 10 x64
  • Linux Mint 20.3
  • macOS 10.15.7

[Prerequisites]:

  • Have the Firefox browser installed and opened.
  • Have the browser’s default “Dark” theme enabled.

[Steps to reproduce]:

  1. Navigate to the “about:welcome” page.
  2. Resize the browser until the “Sign in” button overrides the black part of the Onboarding page.
  3. Observe the “Sign in” button.

[Expected result]:

  • The “Sign in” button is visible on the page.

[Actual result]:

  • The “Sign in” button is hardly visible.

[Notes]:

  • Attached is a screen recording of the issue.

Fx100 only fix that will be reverted back to original UX in Fx101. @jimt should we mark it won'tfix for Fx100 as it impacts signin CTA display on smaller browser width in dark theme

Flags: needinfo?(jimthomas)

Should be optimized to style that's independent of change in background image. We are well past Fx100 uplifts and fix can ride train.

Flags: needinfo?(jimthomas)
Priority: -- → P2
Assignee: nobody → mviar
Attachment #9273871 - Attachment description: WIP: Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled → Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7108e227ba8 The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled r=Mardak,emcminn

https://hg.mozilla.org/mozilla-central/rev/d7108e227ba8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

I have verified that this issue is no longer reproducible using Firefox Nightly 102.0a1, (Build ID - 20220503094208) on LINUX Mint 20.3, Windows10 x64, macOS 12.3.1
The “Sign In” button is now visible when the browser is vertically resized and the Dark Theme is enabled.

Status: RESOLVED → VERIFIED
status-firefox102: fixed → verified

This seems like a pretty low-risk uplift to take on Beta for Fx101. Please nominate the patch for approval if you agree.

status-firefox100: affected → wontfix
Flags: needinfo?(mviar)
status-firefox101: affected → unaffected
Flags: needinfo?(mviar)

Appreciate you flagging this, Ryan. I've updated the bug to show as unaffected in FX101. This patch addresses an issue we saw with an onboarding message configuration specific to FX100. Those changes are reverted in FX101. The patch will make the first onboarding screen more flexible if we change the message configuration in the future, but ok to wait until FX102.

Bug 1763666 reverted to the Fx99 "sign in" link color

Iteration: --- → 102.1 - May 2 - May 13
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1763666
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: