Closed Bug 1765248 Opened 3 years ago Closed 1 years ago

[fission + bfcacheInParent] When going back in a tab that has finished loading in background (while being in another tab), the tab becomes blank. It can be fixed by hovering the tab bar.

Categories

(Core :: DOM: Navigation, defect)

Firefox 101
Desktop
All
defect

Tracking

()

VERIFIED FIXED
115 Branch
Tracking Status
firefox-esr91 --- disabled
firefox-esr102 --- wontfix
firefox99 --- wontfix
firefox100 --- wontfix
firefox101 --- wontfix
firefox102 --- wontfix
firefox112 --- wontfix
firefox113 --- wontfix
firefox114 --- wontfix
firefox115 --- verified
firefox116 --- verified

People

(Reporter: mix5003, Assigned: smaug)

References

(Regression)

Details

(Keywords: correctness, regression)

Attachments

(3 files)

Attached video 20220419_143142.mp4 (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

  1. open this page https://bugzilla.mozilla.org/show_bug.cgi?id=1577383
  2. open new tab
  3. go back to bugzilla tab and click link in Attachemnts section to go to Phabricator and switch to new tab before immediately (i think it should switch tab before Phabricator loaded)
  4. wait for Phabricator loaded
  5. go to Phabricator tab and click back

Actual results:

page is blank but if you resize window page will show again

Expected results:

bugzilla should show correctly

message from mozregression

2022-04-19T14:09:12.765000: DEBUG : Found commit message:
Bug 1732358 - Part 5: Add the fission rollout slug to the GRADUATION_SET, r=mythmon

Depends on D133008

Differential Revision: https://phabricator.services.mozilla.com/D133659

2022-04-19T14:09:12.765000: DEBUG : Did not find a branch, checking all integration branches
2022-04-19T14:09:12.768000: INFO : The bisection is done.
2022-04-19T14:09:12.770000: INFO : Stopped```
Regressed by: 1732358

Set release status flags based on info from the regressing bug 1732358

:nika, since you are the author of the regressor, bug 1732358, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nika)
Has Regression Range: --- → yes

I was able to reproduce this issue a couple of times, but it seems somewhat unreliable. The blank page appearing when the window is resized implies to me that this could be related to BFCache and painting suppression during navigations in some way. Perhaps we stop painting the page as we navigate away and aren't resuming painting when restoring it from BFCache for some reason?

Flags: needinfo?(nika) → needinfo?(peterv)

can you try this step. i think this step should more reliable

  1. go to https://www.ishare.in.th/tmp/bug-1765248/test.html
  2. click link in that page, it will open new tab
  3. wait for all tab loaded, then close tab that just open
  4. click back in first tab.
Flags: needinfo?(bugs)

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → DOM: Navigation
Product: Firefox → Core

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Hi,

Reproduced the issue in release 99, beta 100 and the latest nightly 101.0a1 (2022-05-03) using Windows 10.

Thanks for the report.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true

(In reply to mix5003 from comment #5)

can you try this step. i think this step should more reliable

  1. go to https://www.ishare.in.th/tmp/bug-1765248/test.html
  2. click link in that page, it will open new tab
  3. wait for all tab loaded, then close tab that just open
  4. click back in first tab.

FWIW, if I hover mouse over the tab bar, the page will be displayed again.

Severity: -- → S3
Attached video 2023-04-25_19-35-26_av1-crf55.webm (deleted) —

KDE Wayland, Debian Testing, Intel

  1. Search test1234 in Bugzilla's Advanced Search
  2. Switch to example.com tab
  3. Wait until the Bugzilla tab has finished loading
  4. Switch back to Bugzilla tab
  5. Right click and go back
  6. Tab is empty, but its content can be brought back by hovering the tab bar.

MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --good 2021-04-25 --bad 2023-04-25 -a https://bugzilla.mozilla.org/query.cgi?format=advanced -a https://example.com

12:46.83 INFO: Last good revision: c9d499871dc8c87d1f138d1a954b675df5030a43 (2021-12-13)
12:46.83 INFO: First bad revision: 06c7b4e2d14be1ee8050d6c1eb1ab1bab19ac3c2 (2021-12-14)
12:46.83 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c9d499871dc8c87d1f138d1a954b675df5030a43&tochange=06c7b4e2d14be1ee8050d6c1eb1ab1bab19ac3c2

autoland builds are gone.
Also occurs with MOZ_ENABLE_WAYLAND=0.
Does not occur with fission.autostart:false, therefore likely:

bcf5711345c03edcffc33d7e70e6f59a6c46bfc4 Nika Layzell — Bug 1732358 - Part 4: Enable fission by default on non-android platforms, r=annyG,peterv,pbone,cpeterson


MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --good 2021-01-01 --bad 2021-12-14 -a https://bugzilla.mozilla.org/query.cgi?format=advanced -a https://example.com --pref fission.autostart:true

9:03.99 INFO: Last good revision: 95970359b68e4d468d903493f36471838502a088 (2021-06-20)
9:03.99 INFO: First bad revision: 997f00815e6bc28806b75448c8829f0259d2cb28 (2021-06-21)
9:03.99 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95970359b68e4d468d903493f36471838502a088&tochange=997f00815e6bc28806b75448c8829f0259d2cb28

autoland builds are gone.

MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --launch 2021-06-21 -a https://bugzilla.mozilla.org/query.cgi?format=advanced -a https://example.com --pref fission.autostart:true fission.bfcacheInParent:false
Problem does not occur with first bad build and fission.bfcacheInParent:false, therefore likely:

7d32671931b7c2f5cb24b0f4d62bb6884e484175 Peter Van der Beken — Bug 1715300 - Enable BFCache in parent. r=smaug


MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --good 2021-01-01 --bad 2021-06-21 -a https://bugzilla.mozilla.org/query.cgi?format=advanced -a https://example.com --pref fission.autostart:true fission.bfcacheInParent:true

5:37.94 INFO: Last good revision: b2c9624b48f0dc756adcba7cd43a941f349720f6 (2021-03-02)
5:37.94 INFO: First bad revision: 46580fa5a4ce20c8cf1c7c9f3f520a1e9c644518 (2021-03-03)
5:37.94 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2c9624b48f0dc756adcba7cd43a941f349720f6&tochange=46580fa5a4ce20c8cf1c7c9f3f520a1e9c644518

autoland builds are gone.
This commit added the fission.bfcacheInParent pref:

46bcd486021675805597e341c064bc54712214f7 Olli Pettay — Bug 1689601, add a pref to enable bfcache in parent process, r=peterv

Keywords: correctness
OS: Unspecified → All
Regressed by: 1715300, 1689601
Hardware: Unspecified → Desktop
Summary: when use back button some page may blank when load in background → [fission + bfcacheInParent] When going back in a tab that has finished loading in background (while being in another tab), the tab becomes blank. It can be fixed by hovering the tab bar.

Thanks for the new steps-to-reproduce!
We'll take a look

Assignee: nobody → smaug
Status: NEW → ASSIGNED
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1afba039f877 update renderLayers state when coming out of the bfcache, r=emilio
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Flags: needinfo?(smaug)
Flags: needinfo?(peterv)

The patch landed in nightly and beta is affected.
:smaug, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(smaug)

This is not a recent regression, so hard to justify landing to beta.

Flags: needinfo?(smaug)
Status: RESOLVED → VERIFIED

Verified fixed on KDE Wayland, Debian Testing. Thanks!

QA Whiteboard: [qa-115b-p2]

Reproducible on a 2023-05-08 Nightly build on Windows 10.
Verified as fixed on Firefox 115.0b5(build ID: 20230613195413) and Nightly 116.0a1(build ID: 20230615094111) on Windows 10, macOS 12, Ubuntu 22.

QA Whiteboard: [qa-115b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: