Some more RefreshDriverVsyncObserver cleanup
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•3 years ago
|
||
Nobody was checking the return value anywhere.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Before this patch, a lot of the RefreshDriver vsync timer functionality was in
RefreshDriverVsyncObserver, which is a nested class inside of VsyncRefreshDriverTimer.
This nesting is a bit unwieldy and it sometimes makes it non-obvious whether to
make changes to the timer or to the observer inside the timer.
RefreshDriverVsyncObserver was originally just created to work around lifetime
and threading issues. This patch returns it to just that purpose. All the actual
functionality moves into the timer itself.
Depends on D144360
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D144361
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b5f3c63ebc4d
https://hg.mozilla.org/mozilla-central/rev/ef385ba169cd
https://hg.mozilla.org/mozilla-central/rev/f5d3a6c92036
Description
•