Closed Bug 1766238 Opened 3 years ago Closed 3 years ago

Disallow more than one argument to ChromeUtils.import via ESLint

Categories

(Core :: XPConnect, task)

Product:
Core
Component:
XPConnect
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(8 files, 1 obsolete file)

Bug 1766238 - Stop using the target argument for ChromeUtils.import in OSFile tests. r?barret
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in ExtensionCommon.jsm. r?robwu
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in services. r?leplatrem
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in dom. r?mt
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in caps tests. r?bholley
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in mozscreenshots. r?jaws
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Stop using the target argument for ChromeUtils.import in accessibility tests. r?jamie
(deleted), text/x-phabricator-request
Details
Bug 1766238 - Disallow more than one argument to ChromeUtils.import via ESLint. r?Mossop
(deleted), text/x-phabricator-request
Details

We are almost ready to remove the target (second) argument from ChromeUtils.import which we are planning on doing in bug 1758481.

However, first step is to get the ESLint rule setup to disallow more than one argument and have that passing across the tree. This bug will do that.

There's a few extra cases which aren't covered by ESLint, so they'll be handled in bug 1758481.

Comment on attachment 9273645 [details]
Port Bug 1766238 to Thunderbird - stop passing more than one argument to ChromeUtils.import. r=freaktechnik

Revision D144567 was moved to bug 1766247. Setting attachment 9273645 [details] to obsolete.

Attachment #9273645 - Attachment is obsolete: true
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4daafbfa93e Stop using the target argument for ChromeUtils.import in OSFile tests. r=barret https://hg.mozilla.org/integration/autoland/rev/bf39a6ae228c Stop using the target argument for ChromeUtils.import in ExtensionCommon.jsm. r=robwu https://hg.mozilla.org/integration/autoland/rev/742461a448fc Stop using the target argument for ChromeUtils.import in services. r=leplatrem https://hg.mozilla.org/integration/autoland/rev/cb816df074d5 Stop using the target argument for ChromeUtils.import in dom. r=mt https://hg.mozilla.org/integration/autoland/rev/e162c608408d Stop using the target argument for ChromeUtils.import in caps tests. r=bholley https://hg.mozilla.org/integration/autoland/rev/4fdd63415c26 Stop using the target argument for ChromeUtils.import in mozscreenshots. r=jaws https://hg.mozilla.org/integration/autoland/rev/c266f15c6077 Stop using the target argument for ChromeUtils.import in accessibility tests. r=Jamie https://hg.mozilla.org/integration/autoland/rev/d80fb2266253 Disallow more than one argument to ChromeUtils.import via ESLint. r=mossop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: