Closed
Bug 1766560
Opened 2 years ago
Closed 2 years ago
[CTW] First line start of a leaf is ignored when fetching the next line start
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
101 Branch
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ctw-m2])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Open this test case:
data:text/html,<div contenteditable style="width: 2ch; word-break: break-word;"><span>a</span>bc
- Query the HyperText line offsets at offset 0.
- Expected: (0, 2, "ab")
- Actual: (0, 3, "abc")
This is due to a silly logic error in FindLineStartSameRemoteAcc.
Assignee | ||
Comment 1•2 years ago
|
||
The code previously returned failure for array index 0, but it did this for both movement directions.
It should only do this for eDirPrevious, since we decrement index in that case.
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a901a6c26367
Don't ignore the first line start of a RemoteAccessible when retrieving the next line. r=morgan
Comment 3•2 years ago
|
||
Backed out for causing failures at browser_caching_text.
Backout link: https://hg.mozilla.org/integration/autoland/rev/8372bb6df9bf8b274f3d4fc568716a48802aeec2
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a901a6c263672b4a625a7d5948c8a70d330ca7e6
Failure log: https://treeherder.mozilla.org/logviewer?job_id=376050692&repo=autoland&lineNumber=2640
Flags: needinfo?(jteh)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(jteh)
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc5eb6e5dc92
Don't ignore the first line start of a RemoteAccessible when retrieving the next line. r=morgan
Comment 5•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•