Closed
Bug 1766976
Opened 3 years ago
Closed 2 years ago
Add testcases that checks ESM-ified modules are still accessible with JSM URL
Categories
(Core :: XPConnect, task)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
with bug 1766761, Cu.import("foo.jsm") is supposed to be redirected to Cu.importModule("foo.mjs") if it's already ESM-ified.
With either way proposed there (create a wrapper JSM file, or register a URL to the map), it requires manual task, separated to the actual conversion to the module file,
and in either way, it tends to be overlooked.
We'd better adding a testcase that try to import all (or most of) JSM files to see if it keeps working.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
the bug 1766761 WIP patch implements automatic redirect.
I we can go with it (that has slight de-optimization), this testcase is not necessary.
|
||
Updated•2 years ago
|
Assignee: nobody → arai.unmht
Attachment #9274636 -
Attachment description: WIP: Bug 1766976 - Add testcase that checks JSM import works even after ESM-ification. r?mossop! → Bug 1766976 - Add testcase that checks JSM import works even after ESM-ification. r?Standard8!
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/36e9e0301a24
Add testcase that checks JSM import works even after ESM-ification. r=Standard8
|
||
Comment 4•2 years ago
|
||
Backed out for causing spidermonkey failures on Modules.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/js/src/vm/Modules.cpp:237:10: error: cannot initialize return object of type 'JSObject *' with an rvalue of type 'js::ModuleEnvironmentObject *'
Flags: needinfo?(arai.unmht)
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/495228e057e4
Add testcase that checks JSM import works even after ESM-ification. r=Standard8
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•