Closed
Bug 1767609
Opened 2 years ago
Closed 2 years ago
Split Http2Stream into a base class and separate classes for normal requests, tunnels and websockets
Categories
(Core :: Networking: HTTP, task, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
105 Branch
Tracking | Status | |
---|---|---|
firefox105 | --- | fixed |
People
(Reporter: dragana, Assigned: dragana)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•2 years ago
|
Severity: -- → N/A
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
Pushed by ddamjanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad580df59f14
Create Http2StreamBase r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/dcb265c0e791
Move functions specific to regular HTTP/2 requests, connect requests and server push requests into the appropriate classes. r=necko-reviewers,kershaw
Comment 6•2 years ago
|
||
Backed out for causing build bustages on Http2StreamBase.h
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/netwerk/protocol/http/Http2StreamBase.h:37:32: error: expected class name
Flags: needinfo?(dd.mozilla)
Comment 7•2 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:dragana, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(kershaw)
Flags: needinfo?(dd.mozilla)
Assignee | ||
Comment 8•2 years ago
|
||
I will fix this.
Flags: needinfo?(kershaw)
Flags: needinfo?(dd.mozilla)
Pushed by ddamjanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6cc2bb73c825
Create Http2StreamBase r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/e3ee299fe188
Move functions specific to regular HTTP/2 requests, connect requests and server push requests into the appropriate classes. r=necko-reviewers,kershaw
Comment 10•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6cc2bb73c825
https://hg.mozilla.org/mozilla-central/rev/e3ee299fe188
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•