Open Bug 1767760 Opened 3 years ago Updated 1 year ago

Intermittent devtools/client/framework/test/browser_target_parents.js | single tracking bug

Categories

(DevTools :: Framework, defect, P3)

defect

Tracking

(Not tracked)

REOPENED

People

(Reporter: jmaher, Assigned: ochameau)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell unknown])

Attachments

(4 files)

No description provided.

Filter on devtools-intermittent-singletrackingbug-triage

Severity: -- → S4
Depends on: 1807041

There have been 34 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • linux1804-64-asan-qr
  • linux1804-64-qr
  • windows10-64-2004-ccov-qr
[task 2023-02-03T22:59:37.354Z] 22:59:37     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | For now, worker descriptors and targets are the same object (see bug 1667404) - 
[task 2023-02-03T22:59:37.354Z] 22:59:37     INFO - Buffered messages finished
[task 2023-02-03T22:59:37.357Z] 22:59:37     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:112 - TypeError: can't access property "includes", workerDescriptorFront.name is null
[task 2023-02-03T22:59:37.358Z] 22:59:37     INFO - Stack trace:
[task 2023-02-03T22:59:37.358Z] 22:59:37     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:112:1
[task 2023-02-03T22:59:37.358Z] 22:59:37     INFO - Async*handleTask@chrome://mochikit/content/browser-test.js:1037:26
[task 2023-02-03T22:59:37.358Z] 22:59:37     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1109:18
[task 2023-02-03T22:59:37.358Z] 22:59:37     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1251:14
[task 2023-02-03T22:59:37.359Z] 22:59:37     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1026:14
[task 2023-02-03T22:59:37.360Z] 22:59:37     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1036:13
[task 2023-02-03T22:59:37.360Z] 22:59:37     INFO - Leaving test bound 
[task 2023-02-03T22:59:37.360Z] 22:59:37     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-02-03T22:59:37.360Z] 22:59:37     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-02-03T22:59:37.361Z] 22:59:37     INFO - Stack trace:
[task 2023-02-03T22:59:37.361Z] 22:59:37     INFO - chrome://mochikit/content/browser-test.js:test_ok:1456
[task 2023-02-03T22:59:37.361Z] 22:59:37     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:260
[task 2023-02-03T22:59:37.362Z] 22:59:37     INFO - GECKO(3368) | MEMORY STAT | vsize 3886MB | residentFast 725MB | heapAllocated 341MB
[task 2023-02-03T22:59:37.362Z] 22:59:37     INFO - TEST-OK | devtools/client/framework/test/browser_target_parents.js | took 6134ms
Flags: needinfo?(poirot.alex)
Whiteboard: [stockwell needswork:owner]

There have been 35 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • linux1804-64-asan-qr
  • linux1804-64-qr

There have been 34 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • macosx1015-64-qr
  • linux1804-64-qr

There have been 40 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • windows10-64-2004-ccov-qr
  • linux1804-64-qr

Update:

There have been 53 total failures in the last 7 days.
There are:

  • 7 failures on linux1804-64-asan-qr opt
  • 43 failures on linux1804-64-qr debug
  • 3 failures on windows10-64-2004-ccov-qr opt

Recent failure log.

Alexandre, as the owner of this component, can you help us assign the bug to someone? Thank you.

There have been 47 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • linux1804-64-asan-qr
  • linux1804-64-qr
  • windows11-64-2009-ccov-qr

There have been 45 total failures in the last 7 days.
There are:

  • 40 failures on Linux 18.04 x64 WebRender debug
  • 3 failures on Linux 18.04 x64 WebRender asan opt
  • 2 failures on Windows 11 x64 22H2 CCov WebRender opt

Recent failure log.

In this test we try to instantiate a Worker target for all the parent process workers:
https://searchfox.org/mozilla-central/rev/169bf38e150667afac81ab73ef8b5ace8f1dfa8d/devtools/client/framework/test/browser_target_parents.js#103-104

  for (const workerDescriptorFront of workers) {
    const targetFront = await workerDescriptorFront.getTarget();

But we fail over there with an exception:
https://searchfox.org/mozilla-central/rev/169bf38e150667afac81ab73ef8b5ace8f1dfa8d/devtools/server/connectors/worker-connector.js#36

 dbg.initialize("resource://devtools/server/startup/worker.js");

listWorkers methods may try to ignore such problematic worker. I imagine the worker is being destroyed.
Or it can be a race condition, and the test should probably accept exceptions when calling getTarget.

Flags: needinfo?(poirot.alex)

Update:
There have been 30 total failures in the last 7 days.
There are:

  • 1 failure on linux1804-64-asan-qr opt
  • 29 failures on linux1804-64-qr debug

Recent failure log.

Alexandre , do you have any updates? Thank you.

Flags: needinfo?(poirot.alex)
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/147ec4ca3950 [devtools] Fix browser_target_parents.js when processing defunct worker from previous test. r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e81394b9dc4 [devtools] Also ignore partially initialized workers in browser_target_parents.js. r=devtools-reviewers,bomsy
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

This is still happening: https://treeherder.mozilla.org/logviewer?job_id=414840559&repo=try&lineNumber=4595
TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test bound - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:127 - TypeError: workerDescriptorFront.name is null

[task 2023-05-06T11:29:13.523Z] 11:29:13     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | For now, worker descriptors and targets are the same object (see bug 1667404) - 
[task 2023-05-06T11:29:13.523Z] 11:29:13     INFO - Buffered messages finished
[task 2023-05-06T11:29:13.525Z] 11:29:13     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:127 - TypeError: workerDescriptorFront.name is null
[task 2023-05-06T11:29:13.525Z] 11:29:13     INFO - Stack trace:
[task 2023-05-06T11:29:13.525Z] 11:29:13     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:127:1
[task 2023-05-06T11:29:13.526Z] 11:29:13     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1133:26
[task 2023-05-06T11:29:13.526Z] 11:29:13     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1205:18
[task 2023-05-06T11:29:13.526Z] 11:29:13     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1347:14
[task 2023-05-06T11:29:13.526Z] 11:29:13     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1122:14
[task 2023-05-06T11:29:13.526Z] 11:29:13     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-05-06T11:29:13.527Z] 11:29:13     INFO - Leaving test bound 
[task 2023-05-06T11:29:13.528Z] 11:29:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-06T11:29:13.529Z] 11:29:13     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-05-06T11:29:13.530Z] 11:29:13     INFO - Stack trace:
[task 2023-05-06T11:29:13.530Z] 11:29:13     INFO - chrome://mochikit/content/browser-test.js:test_ok:1584
[task 2023-05-06T11:29:13.531Z] 11:29:13     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:271
[task 2023-05-06T11:29:13.532Z] 11:29:13     INFO - GECKO(1601) | MEMORY STAT | vsize 3861MB | residentFast 664MB | heapAllocated 316MB
[task 2023-05-06T11:29:13.533Z] 11:29:13     INFO - TEST-OK | devtools/client/framework/test/browser_target_parents.js | took 6009ms
[task 2023-05-06T11:29:13.534Z] 11:29:13     INFO - GECKO(1601) | [Child 1805: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f7f87693400 == 1 [pid = 1805] [id = 20]
[task 2023-05-06T11:29:13.535Z] 11:29:13     INFO - GECKO(1601) | [Child 1805: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f7f8d673470) [pid = 1805] [serial = 48] [outer = 0]
[task 2023-05-06T11:29:13.536Z] 11:29:13     INFO - GECKO(1601) | [Child 1805: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7f7f87693800) [pid = 1805] [serial = 49] [outer = 7f7f8d673470]
[task 2023-05-06T11:29:13.537Z] 11:29:13     INFO - checking window state
[task 2023-05-06T11:29:13.538Z] 11:29:13     INFO - TEST-START | devtools/client/framework/test/browser_target_remote.js
Status: RESOLVED → REOPENED
Flags: needinfo?(poirot.alex)
Resolution: FIXED → ---
Target Milestone: 114 Branch → ---

Hi Alexandre! Can you please take another look at this?
Thank you!

Flags: needinfo?(poirot.alex)

It isn't clear why the isDestroyed check isn't enough.
(Note that target and worker are the same object for workers)
But let's ignore workers with null names.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8a30f549278 [devtools] Ignore workers in invalid state. r=devtools-reviewers,nchevobbe
Status: REOPENED → RESOLVED
Closed: 2 years ago1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

Still failing after latest patch: https://treeherder.mozilla.org/logviewer?job_id=416016853&repo=mozilla-central

[task 2023-05-16T21:49:57.271Z] 21:49:57     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | For now, worker descriptors and targets are the same object (see bug 1667404) - 
[task 2023-05-16T21:49:57.272Z] 21:49:57     INFO - Buffered messages finished
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:128 - TypeError: can't access property "includes", workerDescriptorFront.name is null
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - Stack trace:
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:128:1
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1133:26
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1205:18
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1347:14
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1122:14
[task 2023-05-16T21:49:57.274Z] 21:49:57     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-05-16T21:49:57.275Z] 21:49:57     INFO - Leaving test bound 
[task 2023-05-16T21:49:57.276Z] 21:49:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-05-16T21:49:57.277Z] 21:49:57     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-05-16T21:49:57.277Z] 21:49:57     INFO - Stack trace:
[task 2023-05-16T21:49:57.277Z] 21:49:57     INFO - chrome://mochikit/content/browser-test.js:test_ok:1584
[task 2023-05-16T21:49:57.277Z] 21:49:57     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:271
[task 2023-05-16T21:49:57.278Z] 21:49:57     INFO - GECKO(1586) | MEMORY STAT | vsize 3935MB | residentFast 687MB | heapAllocated 321MB
[task 2023-05-16T21:49:57.279Z] 21:49:57     INFO - TEST-OK | devtools/client/framework/test/browser_target_parents.js | took 6982ms
[task 2023-05-16T21:49:57.280Z] 21:49:57     INFO - GECKO(1586) | [Child 1781: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f8ac0261000 == 1 [pid = 1781] [id = 20]
[task 2023-05-16T21:49:57.280Z] 21:49:57     INFO - GECKO(1586) | [Child 1781: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f8ac601d470) [pid = 1781] [serial = 46] [outer = 0]
[task 2023-05-16T21:49:57.281Z] 21:49:57     INFO - GECKO(1586) | [Child 1781: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f8ac0261400) [pid = 1781] [serial = 47] [outer = 7f8ac601d470]
[task 2023-05-16T21:49:57.282Z] 21:49:57     INFO - checking window state
[task 2023-05-16T21:49:57.334Z] 21:49:57     INFO - TEST-START | devtools/client/framework/test/browser_target_remote.js
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 115 Branch → ---

Update

There have been 38 failures within the last 7 days:

  • 3 failures on Linux 18.04 x64 WebRender asan opt
  • 34 failures on Linux 18.04 x64 WebRender debug
  • 1 failure on Windows 11 x64 22H2 CCov WebRender

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=417883197&repo=autoland&lineNumber=4600

[task 2023-06-02T08:44:18.437Z] 08:44:18     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | For now, worker descriptors and targets are the same object (see bug 1667404) - 
[task 2023-06-02T08:44:18.438Z] 08:44:18     INFO - Buffered messages finished
[task 2023-06-02T08:44:18.439Z] 08:44:18     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:128 - TypeError: can't access property "includes", workerDescriptorFront.name is null
[task 2023-06-02T08:44:18.439Z] 08:44:18     INFO - Stack trace:
[task 2023-06-02T08:44:18.440Z] 08:44:18     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:128:1
[task 2023-06-02T08:44:18.440Z] 08:44:18     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1133:26
[task 2023-06-02T08:44:18.441Z] 08:44:18     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1205:18
[task 2023-06-02T08:44:18.441Z] 08:44:18     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1347:14
[task 2023-06-02T08:44:18.442Z] 08:44:18     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1122:14
[task 2023-06-02T08:44:18.442Z] 08:44:18     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-06-02T08:44:18.443Z] 08:44:18     INFO - Leaving test bound 
[task 2023-06-02T08:44:18.444Z] 08:44:18     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-06-02T08:44:18.444Z] 08:44:18     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-06-02T08:44:18.445Z] 08:44:18     INFO - Stack trace:
[task 2023-06-02T08:44:18.445Z] 08:44:18     INFO - chrome://mochikit/content/browser-test.js:test_ok:1582
[task 2023-06-02T08:44:18.445Z] 08:44:18     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:274
[task 2023-06-02T08:44:18.446Z] 08:44:18     INFO - GECKO(1591) | MEMORY STAT | vsize 12075MB | residentFast 702MB | heapAllocated 336MB
[task 2023-06-02T08:44:18.446Z] 08:44:18     INFO - TEST-OK | devtools/client/framework/test/browser_target_parents.js | took 5283ms

Alexandre, did you have the chance to look at this?

Whiteboard: [stockwell unknown] → [stockwell needswork:owner]
Flags: needinfo?(poirot.alex)

Update

There have been 32 failures within the last 7 days:

  • 12 failures on Linux 18.04 x64 WebRender debug
  • 14 failures on OS X 10.15 WebRender opt
  • 2 failures on Windows 11 x64 22H2 WebRender opt/debug
  • 4 failures on Windows 11 x64 22H2 WebRender Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=422475513&repo=autoland&lineNumber=3630

Flags: needinfo?(poirot.alex)
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]

There have been 31 total failures in the last 7 days.
There are:

  • 12 failures on Linux 18.04 x64 WebRender debug
  • 15 failures on OS X 10.15 WebRender opt
  • 4 failures on Windows 11 x64 22H2 WebRender opt

Recent failure log.

[task 2023-07-26T00:06:33.278Z] 00:06:33     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | isWorkerDescriptor is true - 
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - Buffered messages finished
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:112 - TypeError: can't access property "isDestroyed", targetFront is undefined
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - Stack trace:
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:112:1
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-07-26T00:06:33.279Z] 00:06:33     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-07-26T00:06:33.280Z] 00:06:33     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-07-26T00:06:33.280Z] 00:06:33     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-26T00:06:33.280Z] 00:06:33     INFO - Leaving test bound 
[task 2023-07-26T00:06:33.280Z] 00:06:33     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - Stack trace:
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:276
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - GECKO(1713) | MEMORY STAT | vsize 16931MB | residentFast 987MB | heapAllocated 440MB
[task 2023-07-26T00:06:33.281Z] 00:06:33     INFO - TEST-OK | devtools/client/framework/test/browser_target_parents.js | took 935ms

I don't think the targetFront.isDestroyed check makes sense in this catch? If we reach the catch, it means we failed while waiting on workerDescriptorFront.getTarget(). Maybe we should rather use workerDescriptorFront.isDestroyed?

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8f467f91c39 [devtools] Check workerDescriptorFront.isDestroyed in browser_target_parents.js r=devtools-reviewers,nchevobbe
Status: REOPENED → RESOLVED
Closed: 1 years ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

This failure still seems to appear as seen here. Failure log

Status: RESOLVED → REOPENED
Flags: needinfo?(jdescottes)
Resolution: FIXED → ---
Target Milestone: 117 Branch → ---

(In reply to Norisz Fay [:noriszfay] from comment #67)

This failure still seems to appear as seen here. Failure log

Thanks for re-opening, I could also see some failures in my try pushes. Hopefully that fails less often now.

Flags: needinfo?(jdescottes)
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: