Get rid of `nsITransactionListener` interface
Categories
(Core :: DOM: Editor, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
Currently, it's implemented only by ComposerCommandsUpdater.
https://searchfox.org/comm-central/search?q=nsITransactionListener&path=&case=true®exp=false
So we can get rid of this and cut a lot of virtual calls.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
This patch makes TransactionManager store HTMLEditor, and HTMLEditor
send notifications from TransactionManager to ComposerCommandsUpdater.
Depends on D145663
|
|
Assignee | |
Comment 3•2 years ago
|
||
Now, nobody (including comm-central) uses nsITransactionListener interface.
This patch also optimizes the notifying methods of HTMLEditor from
TransactionManager to make them safer and simpler. The HTMLEditor's methods
can drop some arguments, but I'd like to keep them to make new listeners in the
future handle them easier and safer, but the ComposerCommandsUpdater does not
require them. This is the reason why the difference of the methods' arguments.
Depends on D145664
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/214bc2967d67 part 1: Get rid of unhandled methods of `nsITransactionListener` r=m_kato https://hg.mozilla.org/integration/autoland/rev/19b4b6bd0d7f part 2: Make `ComposerCommandsUpdater` stop inheriting `nsITransactionListener` r=m_kato https://hg.mozilla.org/integration/autoland/rev/ae99a0bbee21 part 3: Get rid of `nsITransactionListener` interface r=m_kato
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/214bc2967d67
https://hg.mozilla.org/mozilla-central/rev/19b4b6bd0d7f
https://hg.mozilla.org/mozilla-central/rev/ae99a0bbee21
Description
•