Closed Bug 1768241 Opened 3 years ago Closed 3 years ago

[wayland] Blank webextension popups.

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- unaffected
firefox101 --- unaffected
firefox102 --- fixed

People

(Reporter: emilio, Assigned: mstange)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image image.png (deleted) —

See screenshots. Mozregression says this was caused by bug 1765399, Markus can you take a look?

Flags: needinfo?(mstange.moz)

Will look.

Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED
Flags: needinfo?(mstange.moz)

Set release status flags based on info from the regressing bug 1765399

For the record in case it's useful, the commit that broke this is https://hg.mozilla.org/mozilla-central/rev/22b568631834e556ab8351ac8458d5b24aa638bd according to git bisect.

This is fixing an oversight in a patch that was supposed to be functionally neutral.
https://hg.mozilla.org/mozilla-central/rev/22b568631834e556ab8351ac8458d5b24aa638bd#l1.49

The old code always called UpdateVsyncDispatcher, even if the widget's vsync
source was null, and then UpdateVsyncDispatcher fell back to using the global
vsync source when null was passed.
The new code skipped the call entirely when the vsync dispatcher was null,
so it prevented fallback to the global vsync dispatcher.
Now with this patch, we correctly fall back to the global vsync
dispatcher if the widget's dispatcher is null.

This code only runs on Linux wayland; on other platforms, BrowserParent::mVsyncParent
is always null because nothing calls AllocPVsyncParent.

I've attached a speculative fix based on code inspection. I haven't tested it yet.

(In reply to Markus Stange [:mstange] from comment #5)

I've attached a speculative fix based on code inspection. I haven't tested it yet.

Patch works for me.

Thanks for testing!

I've gone ahead and queued it for landing; smaug can review it on Monday. It's a really simple fix and it just restores previous behavior.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/2bc074934dad Fall back to the global vsync dispatcher when we're on Wayland and there's no widget-local dispatcher.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: