Closed Bug 1768750 Opened 2 years ago Closed 2 years ago

Zoom indicator in URL bar does not get focus outline

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- wontfix
firefox101 --- verified
firefox102 --- verified

People

(Reporter: morgan, Assigned: dao)

References

(Regression)

Details

(Keywords: access, regression)

Attachments

(1 file)

Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details

STR:

  1. Launch FF, go to google.com
  2. Change the zoom level from the default zoom with cmd/ctrl + or cmd/ctrl -
  3. Focus the URL bar with cmd/ctrl + L
  4. Hit tab

Expected: the zoom indicator receives a focus outline
Actual: no focus outline is drawn

I ran mozregression, which pointed me here: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6c069b46b57f9ef2da16aa9487a6f7544507b212&tochange=91956f62a123375565ab58f96f50b6245dd381b8

dao, do you know why this happened? your previous patch seems fairly straightforward

Flags: needinfo?(dao+bmo)

Set release status flags based on info from the regressing bug 1757572

status-firefox100: --- → affected
status-firefox101: --- → affected
status-firefox102: --- → affected
status-firefox-esr91: --- → unaffected
Assignee: nobody → dao+bmo
Severity: -- → S3
Status: NEW → ASSIGNED
status-firefox100: affected → wontfix
Flags: needinfo?(dao+bmo)
Priority: -- → P1
Has Regression Range: --- → yes

Comment on attachment 9276034 [details]
Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9276034 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17c2ed6d4b61 Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Comment on attachment 9276034 [details]
Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Approved for 101.0b6.

Attachment #9276034 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

https://hg.mozilla.org/mozilla-central/rev/17c2ed6d4b61

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
QA Whiteboard: [qa-triaged]

I have reproduced this issue on an affected Nightly build from 2022-05-21, on Win 10 x64.
Verified as fixed on Firefox 101.0b7 (20220515185854) and Firefox 102.0a1 (20220516095144) on Windows 10 x64, macOS 10.14 and Ubuntu 21.04.

Status: RESOLVED → VERIFIED
status-firefox101: fixed → verified
status-firefox102: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: