Closed Bug 1768894 Opened 2 years ago Closed 2 years ago

Refactor LoginManagerChild

Categories

(Toolkit :: Password Manager, task)

Product:
Toolkit
Component:
Password Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: serg, Assigned: serg)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1768894 - Refactor LoginManagerChild r=dimi!
(deleted), text/x-phabricator-request
Details
  • use rootElement instanceof HTMLFormElement instead of ChromeUtils.getClassName(rootElement) === "HTMLFormElement"
  • reduce copy/pasted code
  • remove unused global
  • create LoginFormState class for docState and move _storeUserInput inside
  • use ? where possible
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/223dedbc96dc Fix lint failures. a=lint-fix CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/d57f8660b439
https://hg.mozilla.org/mozilla-central/rev/223dedbc96dc

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: