Closed
Bug 1770204
Opened 3 years ago
Closed 2 years ago
Simplify breakpoint list selectors
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox102 fixed)
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: bomsy, Assigned: bomsy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Simplify breakpoint list selectors
|
Assignee | |
Comment 1•3 years ago
|
||
The selector is already sorting the breakpoints,
so there is no need to re-sort them in the component.
Also Array.sort(stringA-stringB) was misbehaving.
Then I'm using getSourcesMap in order to avoid calling getBreakpointList many times.
Otherwise getSourcesForBreakpoints has to receive the state object
in order to retrieve the source objects.
|
||
Updated•3 years ago
|
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1459819402b
[devtools] Simplify breakpoint list selectors r=nchevobbe
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ac17a9f0e2
Backed out 2 changesets (bug 1770204, bug 1770205) for devtools faolires on browser_dbg-html-breakpoints.js. CLOSED TREE
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b64de7fd715
[devtools] Simplify breakpoint list selectors r=nchevobbe
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
|
||
Comment 6•2 years ago
|
||
Performance alert (improvement) https://treeherder.mozilla.org/perfherder/alerts?id=34233&hideDwnToInv=0
You need to log in
before you can comment on or make changes to this bug.
Description
•