Closed Bug 1770459 Opened 3 years ago Closed 2 years ago

Improve backscroll loading

Categories

(Chat Core :: Matrix, task)

Tracking

(thunderbird102? fixed, thunderbird103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird102 ? fixed
thunderbird103 --- fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

References

Details

Attachments

(2 files)

We currently show more events than we should be as backscroll. There are events leaking in from multiple sources, like decryption of older events.

We could also improve the backscroll loading by not displaying anything before a message that was sent by the current account.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/42d76624220e
Improve Matrix catch up behavior. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attached patch bug1770459-beta.diff (deleted) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Matrix will show messages the user has already seen again and again and some messages may appear out of order.
Testing completed (on c-c, etc.): Minimal testing on c-c, patch not built on beta (but linted fine)
Risk to taking this patch (and alternatives if risky): Honestly, this is rather risky. because it's a big patch with changes deep in the matrix sync logic. I'm not quite sure if this should even be uplifted, since matrix is "preliminarily supported", but in the same vein, as long as it doesn't make it much worse, matrix is only preliminary.

Attachment #9280652 - Flags: approval-comm-beta?

Comment on attachment 9280652 [details] [diff] [review]
bug1770459-beta.diff

[Triage Comment]
Approved for beta

Attachment #9280652 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: