Closed Bug 1770492 Opened 2 years ago Closed 2 years ago

Support primitive values as "arguments" for "script.callFunction" command

Categories

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
enhancement
Points:
5

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [webdriver:m4][webdriver:relnote])

Attachments

(3 files)

Bug 1770492 - [bidi] Support basic "arguments" for "script.callFunction" command
(deleted), text/x-phabricator-request
Details
Bug 1770492 - [messagehandler] Support emitting protocol errors from MessageHandler modules
(deleted), text/x-phabricator-request
Details
Bug 1770492 - [bidi] RemoteValue deserialize should throw when type is not a string
(deleted), text/x-phabricator-request
Details

With bug 1750541 we will get basic support for script.callFunction. This bug covers the addition of handling the arguments parameter and the creation of appropriate webdriver and maybe xpcshell tests.

Depending on the implementation status of deserializing of local values the scope for this bug might have to be cut-down to just primitive protocol values. If that's the case we should split out the remaining work to another bug.

Summary: Support "arguments" for "script.callFunction" command → Support primitive values as "arguments" for "script.callFunction" command
Blocks: 1770798
Blocks: 1770799
Blocks: 1775276
Blocks: 1777460
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Blocks: 1779026
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db9d816614fb [messagehandler] Support emitting protocol errors from MessageHandler modules r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/29be55402599 [bidi] RemoteValue deserialize should throw when type is not a string r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/f2734a746b1a [bidi] Support basic "arguments" for "script.callFunction" command r=webdriver-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/db9d816614fb
https://hg.mozilla.org/mozilla-central/rev/29be55402599
https://hg.mozilla.org/mozilla-central/rev/f2734a746b1a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

We should include the enhancements for Javascript Object deserialization into our release notes but do not want to mention the script.callFunction command given that it is still experimental.

Whiteboard: [webdriver:m4] → [webdriver:m4][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: