Open Bug 1770581 Opened 3 years ago Updated 2 years ago

Some test files still use "await BrowserTestUtils.removeTab"

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

People

(Reporter: kernp25, Unassigned, NeedInfo)

References

Details

When searching for await BrowserTestUtils.removeTab, it will list some test files that still uses await BrowserTestUtils.removeTab.

Bug 1442465 removed the promise.

Flags: needinfo?(rob)
Status: UNCONFIRMED → NEW
Component: General → Session Restore
Ever confirmed: true

With the API not being async any more, await is not strictly necessary.
The presence of it in the test does not break the test (but it does add confusion over whether await is needed).

It may be safe to just remove all awaits, but it is also possible that some tests indirectly relied on the extra tick that await affords. If you'd like, submit a patch that removes await, and see if it sticks (which is quite likely).

Flags: needinfo?(rob)
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1442465

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.