Closed Bug 1770907 Opened 2 years ago Closed 2 years ago

Add Pref to disable ECH GREASE when retrying

Tracking

()

Status:

RESOLVED FIXED

Milestone:

103 Branch

Tracking Flags:

Tracking

Status

firefox103

---

fixed

People

(Reporter: djackson, Assigned: djackson)

References

Details

Attachments

(1 file)

oBug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler 2 years ago Dennis Jackson (deleted), text/x-phabricator-request		Details

Dennis Jackson

Assignee

Description

•

2 years ago

No description provided.

Dennis Jackson

Assignee

Updated

•

2 years ago

Priority: -- → P1

Dennis Jackson

Assignee

Comment 1

•

2 years ago

Attached file oBug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler (deleted) — Details

Add a preference for whether to remove ECH GREASE extensions when retrying a connection. This repurposes the flag which was previously present but not actually functional.

Depends on D145608

Phabricator Automation

Updated

•

2 years ago

Attachment #9277963 - Attachment description: Bug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler → oBug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler

Pulsebot

Comment 2

•

2 years ago

Pushed by djackson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4455b5bf1282 oBug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler,necko-reviewers

Iulian Moraru

Comment 3

•

2 years ago

Backed out for causing xpcshell failures on test_httpssvc_retry_with_ech.js.

Push with failures

Failure log

Backout link

[task 2022-06-10T13:37:35.823Z] 13:37:35     INFO -  TEST-START | netwerk/test/unit/test_httpssvc_retry_with_ech.js
[task 2022-06-10T13:37:37.810Z] 13:37:37  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_httpssvc_retry_with_ech.js | xpcshell return code: 0
[task 2022-06-10T13:37:37.811Z] 13:37:37     INFO -  TEST-INFO took 1988ms
[task 2022-06-10T13:37:37.811Z] 13:37:37     INFO -  >>>>>>>
[task 2022-06-10T13:37:37.811Z] 13:37:37     INFO -  PID 10012 | start!
[task 2022-06-10T13:37:37.811Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 22] "49599" != null
[task 2022-06-10T13:37:37.812Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 22] "49599" != ""
[task 2022-06-10T13:37:37.812Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 40] "62747" != null
[task 2022-06-10T13:37:37.813Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 41] "62747" != ""
[task 2022-06-10T13:37:37.813Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 44] "AE3+DQBJBwAgACBokA2skNPXbdLX9bA2I67WuSRCOW0/MBaZ/1a+4bPGKAAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA==" != null
[task 2022-06-10T13:37:37.814Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | setup - [setup : 45] "AE3+DQBJBwAgACBokA2skNPXbdLX9bA2I67WuSRCOW0/MBaZ/1a+4bPGKAAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA==" != ""
[task 2022-06-10T13:37:37.814Z] 13:37:37     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-06-10T13:37:37.814Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-06-10T13:37:37.815Z] 13:37:37     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-06-10T13:37:37.815Z] 13:37:37     INFO -  running event loop
[task 2022-06-10T13:37:37.815Z] 13:37:37     INFO -  netwerk/test/unit/test_httpssvc_retry_with_ech.js | Starting
[task 2022-06-10T13:37:37.816Z] 13:37:37     INFO -  (xpcshell/head.js) | test pending (2)
[task 2022-06-10T13:37:37.816Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js |  - Binary util EncryptedClientHelloServer should exist - true == true
[task 2022-06-10T13:37:37.817Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js |  - certificate folder (../../../security/manager/ssl/tests/unit/test_encrypted_client_hello) should exist - true == true
[task 2022-06-10T13:37:37.817Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-06-10T13:37:37.817Z] 13:37:37     INFO -  (xpcshell/head.js) | test pending (2)
[task 2022-06-10T13:37:37.817Z] 13:37:37     INFO -  (xpcshell/head.js) | test finished (2)
[task 2022-06-10T13:37:37.818Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-06-10T13:37:37.818Z] 13:37:37     INFO -  (xpcshell/head.js) | test finished (2)
[task 2022-06-10T13:37:37.818Z] 13:37:37     INFO -  netwerk/test/unit/test_httpssvc_retry_with_ech.js | Starting testConnectWithECH
[task 2022-06-10T13:37:37.819Z] 13:37:37     INFO -  (xpcshell/head.js) | test testConnectWithECH pending (2)
[task 2022-06-10T13:37:37.819Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-06-10T13:37:37.819Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 204] asyncResolve ok - true == true
[task 2022-06-10T13:37:37.820Z] 13:37:37     INFO -  PID 10012 | *** Connection Activity 0x3 0x5008 .SA......[tlsflags0x00000000]foo.example.com:53929[TRR:1]
[task 2022-06-10T13:37:37.820Z] 13:37:37     INFO -  PID 10012 | *** Connection Activity 0x3 0x500b .SA......[tlsflags0x00000000]foo.example.com:53929[TRR:1]
[task 2022-06-10T13:37:37.820Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 1] Checking that this is the correct callback - true == true
[task 2022-06-10T13:37:37.821Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 1] Checking status - 0 == 0
[task 2022-06-10T13:37:37.821Z] 13:37:37     INFO -  PID 10012 | *** Connection Activity 0x3 0x5009 .S.......[tlsflags0x00000000]ech-private.example.com:443 <ROUTE-via ech-private.example.com:8443> {NPN-TOKEN http/1.1}^partitionKey=%28https%2Cexample.com%29
[task 2022-06-10T13:37:37.822Z] 13:37:37     INFO -  PID 10012 | *** Connection Activity 0x3 0x500a .S.......[tlsflags0x00000000]ech-private.example.com:443 <ROUTE-via ech-private.example.com:8443> {NPN-TOKEN http/1.1}^partitionKey=%28https%2Cexample.com%29
[task 2022-06-10T13:37:37.822Z] 13:37:37     INFO -  PID 10012 | *** Connection Activity 0x3 0x500b .S.......[tlsflags0x00000000]ech-private.example.com:443 <ROUTE-via ech-private.example.com:8443> {NPN-TOKEN http/1.1}^partitionKey=%28https%2Cexample.com%29
[task 2022-06-10T13:37:37.823Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 213] This host should have accepted ECH - true == true
[task 2022-06-10T13:37:37.823Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 139] Should have one DnsAndSock created - true == true
[task 2022-06-10T13:37:37.824Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 140] Should have echConfig - true == true
[task 2022-06-10T13:37:37.824Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testConnectWithECH - [testConnectWithECH : 141] Should have one connection created - true == true
[task 2022-06-10T13:37:37.824Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 2 pending (2)
[task 2022-06-10T13:37:37.825Z] 13:37:37     INFO -  (xpcshell/head.js) | test testConnectWithECH finished (2)
[task 2022-06-10T13:37:37.825Z] 13:37:37     INFO -  netwerk/test/unit/test_httpssvc_retry_with_ech.js | Starting testEchRetry
[task 2022-06-10T13:37:37.825Z] 13:37:37     INFO -  (xpcshell/head.js) | test testEchRetry pending (2)
[task 2022-06-10T13:37:37.826Z] 13:37:37     INFO -  (xpcshell/head.js) | test run_next_test 2 finished (2)
[task 2022-06-10T13:37:37.826Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testEchRetry - [testEchRetry : 279] asyncResolve ok - true == true
[task 2022-06-10T13:37:37.826Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testEchRetry - [testEchRetry : 1] Checking that this is the correct callback - true == true
[task 2022-06-10T13:37:37.827Z] 13:37:37     INFO -  TEST-PASS | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testEchRetry - [testEchRetry : 1] Checking status - 0 == 0
[task 2022-06-10T13:37:37.827Z] 13:37:37  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_httpssvc_retry_with_ech.js | testEchRetry - [testEchRetry : 289] This host should have accepted ECH - false == true
[task 2022-06-10T13:37:37.828Z] 13:37:37     INFO -  Z:/task_1654866316/build/tests/xpcshell/tests/netwerk/test/unit/test_httpssvc_retry_with_ech.js:testEchRetry:289
[task 2022-06-10T13:37:37.828Z] 13:37:37     INFO -  Z:\task_1654866316\build\tests\xpcshell\head.js:_do_main:240
[task 2022-06-10T13:37:37.828Z] 13:37:37     INFO -  Z:\task_1654866316\build\tests\xpcshell\head.js:_execute_test:597
[task 2022-06-10T13:37:37.828Z] 13:37:37     INFO -  -e:null:1
[task 2022-06-10T13:37:37.829Z] 13:37:37     INFO -  exiting test
[task 2022-06-10T13:37:37.829Z] 13:37:37     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-06-10T13:37:37.829Z] 13:37:37     INFO -  _abort_failed_test@Z:\task_1654866316\build\tests\xpcshell\head.js:868:20
[task 2022-06-10T13:37:37.830Z] 13:37:37     INFO -  do_report_result@Z:\task_1654866316\build\tests\xpcshell\head.js:969:5
[task 2022-06-10T13:37:37.830Z] 13:37:37     INFO -  Assert<@Z:\task_1654866316\build\tests\xpcshell\head.js:75:21
[task 2022-06-10T13:37:37.830Z] 13:37:37     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2022-06-10T13:37:37.831Z] 13:37:37     INFO -  proto.ok@resource://testing-common/Assert.jsm:254:10
[task 2022-06-10T13:37:37.831Z] 13:37:37     INFO -  testEchRetry@Z:/task_1654866316/build/tests/xpcshell/tests/netwerk/test/unit/test_httpssvc_retry_with_ech.js:289:10
[task 2022-06-10T13:37:37.831Z] 13:37:37     INFO -  _do_main@Z:\task_1654866316\build\tests\xpcshell\head.js:240:6
[task 2022-06-10T13:37:37.832Z] 13:37:37     INFO -  _execute_test@Z:\task_1654866316\build\tests\xpcshell\head.js:597:5
[task 2022-06-10T13:37:37.832Z] 13:37:37     INFO -  @-e:1:1
[task 2022-06-10T13:37:37.832Z] 13:37:37     INFO -  exiting test
[task 2022-06-10T13:37:37.832Z] 13:37:37     INFO -  "Force a GC"
[task 2022-06-10T13:37:37.833Z] 13:37:37     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NetworkError: Network request failed" {file: "resource://services-settings/Utils.jsm" line: 242}]
[task 2022-06-10T13:37:37.833Z] 13:37:37     INFO -  fetch/</request.onerror@resource://services-settings/Utils.jsm:242:26
[task 2022-06-10T13:37:37.833Z] 13:37:37     INFO -  _execute_test@Z:\\task_1654866316\\build\\tests\\xpcshell\\head.js:698:23
[task 2022-06-10T13:37:37.834Z] 13:37:37     INFO -  @-e:1:1
[task 2022-06-10T13:37:37.834Z] 13:37:37     INFO -  "
[task 2022-06-10T13:37:37.834Z] 13:37:37     INFO -  <<<<<<<
[task 2022-06-10T13:37:37.848Z] 13:37:37     INFO -  TEST-START | netwerk/test/unit/test_httpssvc_retry_without_ech.js

Flags: needinfo?(djackson)

Pulsebot

Comment 4

•

2 years ago

Pushed by djackson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c5b23b2d4a9 oBug 1770907 - Disable ECH GREASE when retrying connections. r=dragana,keeler,necko-reviewers

Dennis Jackson

Assignee

Updated

•

2 years ago

Status: NEW → RESOLVED

Closed: 2 years ago

Flags: needinfo?(djackson)

Resolution: --- → FIXED

Ryan VanderMeulen [:RyanVM]

Comment 5

•

2 years ago

https://hg.mozilla.org/mozilla-central/rev/8c5b23b2d4a9c36724783122c105a7e46a3d2677

status-firefox103: --- → fixed

Target Milestone: --- → 103 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Add Pref to disable ECH GREASE when retrying

Categories

(Core :: Networking, enhancement, P1)

Tracking

()

People

(Reporter: djackson, Assigned: djackson)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Comment 1

Updated

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Attachment

General

Description

File Name

Content Type