Remove dom/browser-element/BrowserElementParent.jsm
Categories
(Core :: DOM: Content Processes, task, P2)
Tracking
()
People
(Reporter: mccr8, Assigned: aiunusov)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
It sounds like this isn't used any more, so we should try removing it. Gijs said it was confusing to have this around, because it kind of looks like something useful, but it isn't actually.
Reporter | ||
Comment 1•3 years ago
|
||
jstutte said jkrause might be able to work on this, so I'll mark them as the assignee for now.
Comment 3•3 years ago
|
||
Note that the various references to the "mozbrowser" attribute should also be removed.
Please flag me for review. Thanks!
Reporter | ||
Comment 4•2 years ago
|
||
Presumably everything under dom/browser-element/ can be removed. You should also talk to smaug after that happens, so he can deal with getting the module for this code removed.
Comment 5•2 years ago
|
||
I will split it into several commits to make it easier to review.
Comment 6•2 years ago
|
||
Comment 7•2 years ago
|
||
I think we should also remove dom/interfaces/html/nsIMozBrowserFrame.idl
and related code.
Comment 8•2 years ago
|
||
(Thanks for working on this!)
Comment 9•2 years ago
|
||
Module owner thanks :)
And yes, please remove the interface too and all the places it is used. That can be a separate patch.
Looks like there is also nsIDOMMozBrowserFrame.
Comment 11•2 years ago
|
||
Depends on D155254
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jkrause, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Comment 14•2 years ago
|
||
jkrause, hmm, should we land the patches.
https://phabricator.services.mozilla.com/D175898 has some error in moz.build
Comment 15•2 years ago
|
||
I will fix the errors in moz.build
.
Lastly, there will be some more patches removing the attribute mInIsolatedMozBrowser
and some dangling textual references of mozbrowser
.
What about deprecated methods like nsIDocShell getSameTypeInProcessParentIgnoreBrowserBoundaries()
?
Updated•1 year ago
|
Comment 16•1 year ago
|
||
Depends on D175898
Comment 17•1 year ago
|
||
Depends on D183229
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Description
•