Open Bug 1770944 Opened 3 years ago Updated 1 year ago

Remove dom/browser-element/BrowserElementParent.jsm

Categories

(Core :: DOM: Content Processes, task, P2)

task

Tracking

()

People

(Reporter: mccr8, Assigned: aiunusov)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

It sounds like this isn't used any more, so we should try removing it. Gijs said it was confusing to have this around, because it kind of looks like something useful, but it isn't actually.

jstutte said jkrause might be able to work on this, so I'll mark them as the assignee for now.

Assignee: nobody → jkrause
Flags: needinfo?(jkrause)

Yes, I'm on it. Thank you.

Flags: needinfo?(jkrause)

Note that the various references to the "mozbrowser" attribute should also be removed.

Please flag me for review. Thanks!

Presumably everything under dom/browser-element/ can be removed. You should also talk to smaug after that happens, so he can deal with getting the module for this code removed.

I will split it into several commits to make it easier to review.

I think we should also remove dom/interfaces/html/nsIMozBrowserFrame.idl and related code.

(Thanks for working on this!)

Module owner thanks :)

And yes, please remove the interface too and all the places it is used. That can be a separate patch.
Looks like there is also nsIDOMMozBrowserFrame.

Depends on D155254

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jkrause, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(smaug)
Flags: needinfo?(jkrause)

jkrause, hmm, should we land the patches.
https://phabricator.services.mozilla.com/D175898 has some error in moz.build

Flags: needinfo?(smaug)

I will fix the errors in moz.build.

Lastly, there will be some more patches removing the attribute mInIsolatedMozBrowser and some dangling textual references of mozbrowser.

What about deprecated methods like nsIDocShell getSameTypeInProcessParentIgnoreBrowserBoundaries()?

Flags: needinfo?(jkrause)

Depends on D175898

Depends on D183229

Assignee: jan.rio.krause → aiunusov
Priority: P3 → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: