Closed
Bug 1770959
Opened 3 years ago
Closed 3 years ago
Debugger parse URL via whatwg-url module and is slow
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox102 fixed)
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The debugger uses whatwg-url from a unique callsite over there:
https://searchfox.org/mozilla-central/rev/1c391443f770eddc7cde9e52dba5ef50cc233c06/devtools/client/debugger/src/utils/url.js#5
But this is called for parsing lots of URLs and appears to be slow.
It looks like moving to parse the URL via the URL constructor is much faster. At least it no longer appears as a major cost in the profiler.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
|
|
||
Updated•3 years ago
|
Attachment #9277970 -
Attachment description: Bug 1770959 - Use standard URL constructor instead of whatwg-url module → Bug 1770959 - [devtools] Use standard URL constructor instead of whatwg-url module.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf5baa8bec21
[devtools] Use standard URL constructor instead of whatwg-url module. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
|
||
Comment 4•3 years ago
|
||
Performance alert (improvement): https://treeherder.mozilla.org/perfherder/alerts?id=34216&hideDwnToInv=0
You need to log in
before you can comment on or make changes to this bug.
Description
•