EmptyLines's disableEmptyLines method is still called too many times
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1769795 wasn't enough, disableEmptyLines is still called many times. Less, but still too many times with a real life firefox profile.
What happens is that props.breakableLines ends up being a new empty Set instance, or, the same Set again and again.
That's because the selectors around breakableLines return a new array everytime they get called for non-original sources...
https://searchfox.org/mozilla-central/rev/1c391443f770eddc7cde9e52dba5ef50cc233c06/devtools/client/debugger/src/selectors/source-actors.js#96-105
|
Assignee | |
Comment 1•2 years ago
|
||
breakableLines wasn't correctly memoized for sources other than the original ones.
This patch at least fix this for regular JS files sources, but the issue still
happens for HTML sources having more than one source actor.
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
Performance alert (improvement) https://treeherder.mozilla.org/perfherder/alerts?id=34239&hideDwnToInv=0
Description
•