Closed Bug 1771092 Opened 2 years ago Closed 2 years ago

Support ESM in ChromeUtils.registerWindowActor

Categories

(Core :: DOM: Content Processes, task)

Product:
Core
Component:
DOM: Content Processes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 1771092 - Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r?kmag!
(deleted), text/x-phabricator-request
Details
Bug 1771092 - Part 2: Add tests for process/window actors with ESM. r?kmag!
(deleted), text/x-phabricator-request
Details
Bug 1771092 - Part 3: Add tests JSM and ESM URIs combination. r?kmag!
(deleted), text/x-phabricator-request
Details

ChromeUtils.registerWindowActor receives the URL of JSM as moduleURI property.
To support ESM, it needs:

  • Decide the way to pass ESM URI
  • Support loading module inside it
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #9278322 - Attachment description: WIP: Bug 1771092 - Add esmURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading syste ESM. r?kmag! → Bug 1771092 - Part 1: Add esmURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading syste ESM. r?kmag!
Attachment #9278322 - Attachment description: Bug 1771092 - Part 1: Add esmURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading syste ESM. r?kmag! → Bug 1771092 - Part 1: Add esmURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r?kmag!

Depends on D147587

Depends on: 1771678
Attachment #9278322 - Attachment description: Bug 1771092 - Part 1: Add esmURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r?kmag! → Bug 1771092 - Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r?kmag!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/a49f754ca73f Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/25b43856bc00 Part 2: Add tests for process/window actors with ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/f0537d333adc Part 3: Add tests JSM and ESM URIs combination. r=kmag

conflicted with bug 1773472.
will address in bug 1774647

(bug 1769002 comment #4)

Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc95bf5ad7c5e9bca85278b59608cc9190fdc27d

Push with failures

Failure log lint black

Failure log es lint

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestProcessActorChild.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
EST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowChild.sys.mjs:11:1 | Prefer default export. (import/prefer-default-export)
[task 2022-06-16T17:07:08.660Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/actors/TestWindowParent.sys.mjs:9:1 | Prefer default export. (import/prefer-default-export)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/072323bc72cc Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/f4e27a35c83c Part 2: Add tests for process/window actors with ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/8a4d712f819a Part 3: Add tests JSM and ESM URIs combination. r=kmag

Backed out for causing mochitest failures on browser_sendQuery.js

Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | dom/ipc/tests/JSProcessActor/browser_sendQuery.js | Error should have the correct stack - Got "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:32:31\n", expected "receiveMessage@resource://testing-common/TestProcessActorChild.sys.mjs:31:31\n"

Flags: needinfo?(arai.unmht)

so, apparently we cannot reorder this patch and bug 1774647 cleanly.

Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/46e082c3f939 Part 1: Add esModuleURI key to ProcessActorSidedOptions/WindowActorSidedOptions and support loading system ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/31279c78d127 Part 2: Add tests for process/window actors with ESM. r=kmag https://hg.mozilla.org/integration/autoland/rev/b738d1f76f5d Part 3: Add tests JSM and ESM URIs combination. r=kmag

https://hg.mozilla.org/mozilla-central/rev/46e082c3f939
https://hg.mozilla.org/mozilla-central/rev/31279c78d127
https://hg.mozilla.org/mozilla-central/rev/b738d1f76f5d

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: