Closed Bug 1771841 Opened 2 years ago Closed 2 years ago

use HTMLInputElement.isInstance(field) instead of ChromeUtils.getClassName(field) === "HTMLInputElement"

Categories

(Toolkit :: Password Manager, task, P1)

Product:
Toolkit
Component:
Password Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: serg, Assigned: serg)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1771841 - use HTMLInputElement.isInstance(field) instead of ChromeUtils.getClassName(field) === "HTMLInputElement". r=dimi!
(deleted), text/x-phabricator-request
Details

HTMLInputElement.isInstance(field) vs ChromeUtils.getClassName(field) === "HTMLInputElement":

  • is approximately 25% faster
  • does not require temporary string allocation
  • works with custom elements derived from HTMLInputElement
  • can be recognized by tooling as class name
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72292afcfc40 use HTMLInputElement.isInstance(field) instead of ChromeUtils.getClassName(field) === "HTMLInputElement". r=dimi
Priority: -- → P1

https://hg.mozilla.org/mozilla-central/rev/72292afcfc40

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: