Closed
Bug 177189
Opened 22 years ago
Closed 15 years ago
a bug in ime mouse operation
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: shanjian, Assigned: masayuki)
References
Details
(Keywords: inputmethod, intl)
Attachments
(1 file)
|
(deleted),
patch
|
mkaply
:
review+
|
Details | Diff | Splinter Review |
ftang pointed out that in following statements, the if will always be false.
mIMECompCharPos[mIMECursorPosition-1].right =
event.theReply.mCursorPosition.x;
mIMECompCharPos[mIMECursorPosition-1].top = event.theReply.mCursorPosition.y;
mIMECompCharPos[mIMECursorPosition-1].bottom =
event.theReply.mCursorPosition.YMost();
if (mIMECompCharPos[mIMECursorPosition-1].top !=
event.theReply.mCursorPosition.y) {
// wrapping, invalidate left position
mIMECompCharPos[mIMECursorPosition-1].left = -1;
}
The right code should be :
if (mIMECompCharPos[mIMECursorPosition-1].top !=
event.theReply.mCursorPosition.y) {
// wrapping, invalidate left position
mIMECompCharPos[mIMECursorPosition-1].left = -1;
}
mIMECompCharPos[mIMECursorPosition-1].right =
event.theReply.mCursorPosition.x;
mIMECompCharPos[mIMECursorPosition-1].top = event.theReply.mCursorPosition.y;
mIMECompCharPos[mIMECursorPosition-1].bottom =
event.theReply.mCursorPosition.YMost();
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Attachment #104507 -
Flags: review?(ftang)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 104507 [details] [diff] [review]
patch
r=mkaply
Attachment #104507 -
Flags: review?(ftang) → review+
|
||
Updated•15 years ago
|
QA Contact: amyy → i18n
|
Assignee | |
Updated•15 years ago
|
Keywords: inputmethod
|
|
Assignee | |
Comment 4•15 years ago
|
||
The code was refactored by bug 492233.
Assignee: shanjian → masayuki
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Component: Internationalization → Widget: Win32
Depends on: 492233
QA Contact: i18n → win32
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•