Closed Bug 1772064 Opened 2 years ago Closed 2 years ago

Startup crash in @nsImapIncomingServer::DiscoveryDone

Categories

(MailNews Core :: Networking: IMAP, defect)

Thunderbird 102
defect

Tracking

(thunderbird_esr102 fixed, thunderbird102+ verified)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird_esr102 --- fixed
thunderbird102 + verified

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: crash, topcrash-thunderbird)

Crash Data

Attachments

(1 file)

Per bug 1749276 comment 47:
nsImapIncomingServer::DiscoveryDone - 102.0b1 didn't start in safe mode - bp-678ca790-04cf-4348-83b8-e52a20220601
0 XUL nsImapIncomingServer::DiscoveryDone() mailnews/imap/src/nsImapIncomingServer.cpp:1429
1 XUL (anonymous namespace)::SyncRunnable0<nsIImapServerSink>::Run() mailnews/imap/src/nsSyncRunnableHelpers.cpp:78
2 XUL mozilla::RunnableTask::Run() xpcom/threads/TaskController.cpp:475
3 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) xpcom/threads/TaskController.cpp:788

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED

regression?

Severity: -- → S2
Summary: crash in @nsImapIncomingServer::DiscoveryDone → Startup crash in @nsImapIncomingServer::DiscoveryDone
Version: unspecified → Thunderbird 102

Something elsewhere must have changed, to trigger this, or trigger it differently. The code had the missing error check forever.

Possibly exposed due to the fix for bug 1759883.

Looks like it should be safe for beta?

(copying from bug 1772287) Begins at Build ID 20220521102659 102.0a1 Crash report: https://crash-stats.mozilla.org/report/index/7dde7824-5e09-4216-9f93-98fef0220522

bug 1759883 landed May 12. So it's in fair proximity to bug 1759883.

Regressed by: 1759883
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(gds)

Hard to say what happened there. Probably unrelated to this(??). Maybe related to realhostname migration.

Flags: needinfo?(mkmelin+mozilla)

bug 1759883 landed May 12. So it's in fair proximity to bug 1759883.

If caused by this it would be oauth2 specific, e.g., gmail. Anyhow, looks like Magnus has a proposed fix.

Flags: needinfo?(gds)

I have noticed something a few weeks ago which may be related to bug 1759883, or an earlier patch - I've seen it more than once on gmail accounts, the gmail special folders may not be presented early enough and as a result Thunderbird creates its own, for example Trash or Sent folder.

This is blocking increasing the beta update rate, so let's see if we can get someone else to review this instead of waiting 10 more hours.

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/74d6c1c945b9
crash in @nsImapIncomingServer::DiscoveryDone. r=lasana

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Comment on attachment 9279042 [details]
Bug 1772064 - crash in @nsImapIncomingServer::DiscoveryDone. r=benc

[Triage Comment]
Approved for 102.0beta per wsmwk.

Attachment #9279042 - Flags: approval-comm-beta+

(In reply to Wayne Mery (:wsmwk) from comment #10)

I have noticed something a few weeks ago which may be related to bug 1759883, or an earlier patch - I've seen it more than once on gmail accounts, the gmail special folders may not be presented early enough and as a result Thunderbird creates its own, for example Trash or Sent folder.

Are you seeing new Trash and Sent at top level or under [Gmail]/ ? Is this on new accounts or existing accounts? Do you still see original Trash and Sent under [Gmail]/ ?
This type of thing occurred before but was supposed to be fixed: bug 1579304 comment 8, etc.
Also, the approved patch in comment 11 above only affects non-gmail related crashes. Wrong, it affects all accounts that move deleted mail to the designated trash mailbox.

Crash Signature: [@ nsImapIncomingServer::DiscoveryDone]

Thanks everyone for the quick fix. The crash signature is gone according to crash stats.

It does happen rarely in version 91, but not often enough IMO to uplift.

There is also this rare signature in version 91... nsMsgDBFolder::GetFoldersWithFlags
Crash report: https://crash-stats.mozilla.org/report/index/2e38b191-f317-4769-9b3c-2097d0220513

Reason: EXCEPTION_ACCESS_VIOLATION_WRITE

Top 10 frames of crashing thread:

0 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4017
1 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4013
2 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4013
3 xul.dll nsImapIncomingServer::DiscoveryDone mailnews/imap/src/nsImapIncomingServer.cpp:1395
4 xul.dll `anonymous namespace'::SyncRunnable0<nsIImapMailFolderSink>::Run mailnews/imap/src/nsSyncRunnableHelpers.cpp:78
5 xul.dll mozilla::RunnableTask::Run xpcom/threads/TaskController.cpp:502
6 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:805
7 xul.dll mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:641
8 xul.dll mozilla::TaskController::ProcessPendingMTTask xpcom/threads/TaskController.cpp:425
9 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:135:7'>::Run xpcom/threads/nsThreadUtils.h:532
Blocks: tb102found
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: