Startup crash in @nsImapIncomingServer::DiscoveryDone
Categories
(MailNews Core :: Networking: IMAP, defect)
Tracking
(thunderbird_esr102 fixed, thunderbird102+ verified)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: crash, topcrash-thunderbird)
Crash Data
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details |
Per bug 1749276 comment 47:
nsImapIncomingServer::DiscoveryDone - 102.0b1 didn't start in safe mode - bp-678ca790-04cf-4348-83b8-e52a20220601
0 XUL nsImapIncomingServer::DiscoveryDone() mailnews/imap/src/nsImapIncomingServer.cpp:1429
1 XUL (anonymous namespace)::SyncRunnable0<nsIImapServerSink>::Run() mailnews/imap/src/nsSyncRunnableHelpers.cpp:78
2 XUL mozilla::RunnableTask::Run() xpcom/threads/TaskController.cpp:475
3 XUL mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) xpcom/threads/TaskController.cpp:788
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Comment 3•2 years ago
|
||
regression?
Assignee | ||
Comment 4•2 years ago
|
||
Something elsewhere must have changed, to trigger this, or trigger it differently. The code had the missing error check forever.
Assignee | ||
Comment 5•2 years ago
|
||
Possibly exposed due to the fix for bug 1759883.
Comment 6•2 years ago
|
||
Looks like it should be safe for beta?
(copying from bug 1772287) Begins at Build ID 20220521102659 102.0a1 Crash report: https://crash-stats.mozilla.org/report/index/7dde7824-5e09-4216-9f93-98fef0220522
bug 1759883 landed May 12. So it's in fair proximity to bug 1759883.
Comment 7•2 years ago
|
||
Might this fix resolve https://thunderbird.topicbox.com/groups/beta/T451e1919736cf5fe-Md4edc0f87805feec83d12e9c ?
Assignee | ||
Comment 8•2 years ago
|
||
Hard to say what happened there. Probably unrelated to this(??). Maybe related to realhostname migration.
Comment 9•2 years ago
|
||
bug 1759883 landed May 12. So it's in fair proximity to bug 1759883.
If caused by this it would be oauth2 specific, e.g., gmail. Anyhow, looks like Magnus has a proposed fix.
Comment 10•2 years ago
|
||
I have noticed something a few weeks ago which may be related to bug 1759883, or an earlier patch - I've seen it more than once on gmail accounts, the gmail special folders may not be presented early enough and as a result Thunderbird creates its own, for example Trash or Sent folder.
This is blocking increasing the beta update rate, so let's see if we can get someone else to review this instead of waiting 10 more hours.
Comment 11•2 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/74d6c1c945b9
crash in @nsImapIncomingServer::DiscoveryDone. r=lasana
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Comment on attachment 9279042 [details]
Bug 1772064 - crash in @nsImapIncomingServer::DiscoveryDone. r=benc
[Triage Comment]
Approved for 102.0beta per wsmwk.
Comment 13•2 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #10)
I have noticed something a few weeks ago which may be related to bug 1759883, or an earlier patch - I've seen it more than once on gmail accounts, the gmail special folders may not be presented early enough and as a result Thunderbird creates its own, for example Trash or Sent folder.
Are you seeing new Trash and Sent at top level or under [Gmail]/ ? Is this on new accounts or existing accounts? Do you still see original Trash and Sent under [Gmail]/ ?
This type of thing occurred before but was supposed to be fixed: bug 1579304 comment 8, etc.
Also, the approved patch in comment 11 above only affects non-gmail related crashes. Wrong, it affects all accounts that move deleted mail to the designated trash mailbox.
Updated•2 years ago
|
Comment 14•2 years ago
|
||
Thunderbird 102.0beta2:
https://hg.mozilla.org/releases/comm-beta/rev/48df8d17f07b73d9237f99865f23f901bc1d53c5
Comment 15•2 years ago
|
||
Thanks everyone for the quick fix. The crash signature is gone according to crash stats.
It does happen rarely in version 91, but not often enough IMO to uplift.
There is also this rare signature in version 91... nsMsgDBFolder::GetFoldersWithFlags
Crash report: https://crash-stats.mozilla.org/report/index/2e38b191-f317-4769-9b3c-2097d0220513
Reason: EXCEPTION_ACCESS_VIOLATION_WRITE
Top 10 frames of crashing thread:
0 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4017
1 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4013
2 xul.dll nsMsgDBFolder::GetFoldersWithFlags mailnews/base/src/nsMsgDBFolder.cpp:4013
3 xul.dll nsImapIncomingServer::DiscoveryDone mailnews/imap/src/nsImapIncomingServer.cpp:1395
4 xul.dll `anonymous namespace'::SyncRunnable0<nsIImapMailFolderSink>::Run mailnews/imap/src/nsSyncRunnableHelpers.cpp:78
5 xul.dll mozilla::RunnableTask::Run xpcom/threads/TaskController.cpp:502
6 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:805
7 xul.dll mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:641
8 xul.dll mozilla::TaskController::ProcessPendingMTTask xpcom/threads/TaskController.cpp:425
9 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:135:7'>::Run xpcom/threads/nsThreadUtils.h:532
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Description
•