Tests are needed for repeated saving to be sure that no leaking of other contact data is happening

The repeated saving should also include the other fields like Phone Numbers, Websites, Addresses, ... .
This follows next.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f6dafb9848e4
Address book edit test for the N field with repeated savings. r=darktrojan

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f600a1f79e74
Contact editing email field test coverage with repeated savings. r=darktrojan
https://hg.mozilla.org/comm-central/rev/57a1b8a23f56
Test coverage for the edit address book fields IMPP, URL, TEL and NOTE. r=darktrojan

Comment on attachment 9279094 [details]
Bug 1772119 - Address book edit test for the N field with repeated savings. r=darktrojan

[Approval Request Comment]
User impact if declined: These are tests for the new edit contact entries. For upcoming uplifts they are important to verify that the UI works. This patch is for the name field.
Testing completed (on c-c, etc.): on c-c, e.g. opt linux https://treeherder.mozilla.org/logviewer?job_id=381853260&repo=comm-central&lineNumber=5156
Risk to taking this patch (and alternatives if risky): This patch reduces the risk by running the tests on the beta/esr.

Comment on attachment 9279607 [details]
Bug 1772119 - Contact editing email field test coverage with repeated savings. r=darktrojan

[Approval Request Comment]
User impact if declined: These are tests for the new edit contact entries. For upcoming uplifts they are important to verify that the UI works. This patch includes the email fields.
Testing completed (on c-c, etc.): on c-c, e.g. opt linux https://treeherder.mozilla.org/logviewer?job_id=381853260&repo=comm-central&lineNumber=5156
Risk to taking this patch (and alternatives if risky): This patch reduces the risk by running the tests on beta/esr.

Comment on attachment 9280042 [details]
Bug 1772119 - Test coverage for the edit address book fields IMPP, URL, TEL and NOTE. r=darktrojan

[Approval Request Comment]
User impact if declined: These are tests for the new edit contact entries. For upcoming uplifts they are important to verify that the UI works. This patch includes the IMPP, URL, Tel and NOTE fields.
Testing completed (on c-c, etc.): on c-c, e.g. opt linux https://treeherder.mozilla.org/logviewer?job_id=381853260&repo=comm-central&lineNumber=5156
Risk to taking this patch (and alternatives if risky): This patch reduces the risk by running the tests on beta/esr.

Comment on attachment 9280042 [details]
Bug 1772119 - Test coverage for the edit address book fields IMPP, URL, TEL and NOTE. r=darktrojan

[Triage Comment]
Approved for beta

Comment on attachment 9279094 [details]
Bug 1772119 - Address book edit test for the N field with repeated savings. r=darktrojan

[Triage Comment]
Approved for beta

Comment on attachment 9279607 [details]
Bug 1772119 - Contact editing email field test coverage with repeated savings. r=darktrojan

[Triage Comment]
Approved for beta

Thunderbird 102.0beta8:
https://hg.mozilla.org/releases/comm-beta/rev/8a28fb0f9e30
https://hg.mozilla.org/releases/comm-beta/rev/4036c1342a44
https://hg.mozilla.org/releases/comm-beta/rev/1ba9e19fbc8f

We're missing tests for editing (multiple) addresses, anniversary, birthday, timezone and organizational properties.

Is this bug still open because these will be added here, or should I open a new bug?

(In reply to Henry Wilkes (they/them) [:henry] from comment #15)

We're missing tests for editing (multiple) addresses, anniversary, birthday, timezone and organizational properties.

Is this bug still open because these will be added here, or should I open a new bug?

Nevermind, I just realised there is a pending patch that does this.

As a reminder for me:
Bug 1774696 - Fix layout of the special date field
Needs to be addressed for the tests.

How come there's a 2 months old patch here that didn't land?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/acd28aa99431
Edit address book tests for the rest of the properties. r=darktrojan

Comment on attachment 9281366 [details]
Bug 1772119 - Edit address book tests for the rest of the properties. r=darktrojan

[Triage Comment]
Test-only code that really should be on c-esr102. It appears the code being tested is present.

Reminder to uplift acd28aa99431 to c-esr102.

Thunderbird 102.3.1:
https://hg.mozilla.org/releases/comm-esr102/rev/5d5c6d0048e9