More structure for nsHttpConnection
Categories
(Core :: Networking: HTTP, enhancement, P3)
Tracking
()
People
(Reporter: dragana, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The following nsHttpConnection functions are specific to and only used by HTTP/1.1/1.0 or HTTP/2 protocol:
- HTTP/1./1.0 related:
- TryTakeSubTransactions
- UpdateTCPKeepalive
- BeginIdleMonitoring
- EndIdleMonitoring
- StartShortLivedTCPKeepalives
- StartLongLivedTCPKeepalives
- DisableTCPKeepalives
- HTTP/2 related:
- MoveTransactionsToSpdy
- Start0RTTSpdy
- StartSpdy
- Reset0RttForSpdy
- AddTransaction
This can be isolated. Many other functions have 2 separate behaviors for the 2 versions and can be factored out better for easier reading the code.
Reporter | ||
Comment 1•2 years ago
|
||
nsHttpConnection is used for HTTP/1.1(and smaller) and for HTTP/2. The behavior of nsHttpConnection is a bit different for the 2 versions, e.g. HTTP/1.1 uses tcp keep-alive and HTTP/2 implements its own pings.
This patch takes out from nsHttpConnection the specific behavior of the 2 types into Http1VersionSpecific and Http2VersonSpecific classes.
Also remove SpdyInformation snce we only have one version od spdy now, i.e. HTTP/2.
Updated•2 years ago
|
Reporter | ||
Comment 2•2 years ago
|
||
I will not have time to work on this bug, so I am unassigning myself.
Reporter | ||
Comment 3•2 years ago
|
||
Valentin, please take a look at the patch if you want to finish it or just abandon it. Thank you.
Description
•